From e6bae7d01f10b8af63ce1ff23ae2a3eb6aa8fe28 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Thu, 17 Apr 2025 10:04:45 +0100 Subject: [PATCH] MDL-85229 mod_url: observe description appearance setting on display. Correctly determine whether said description is in fact "empty". --- mod/url/locallib.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mod/url/locallib.php b/mod/url/locallib.php index ed3f63873be..499cde89b97 100644 --- a/mod/url/locallib.php +++ b/mod/url/locallib.php @@ -182,8 +182,8 @@ function url_print_header($url, $cm, $course) { */ function url_get_intro(object $url, object $cm, bool $ignoresettings = false): string { $options = empty($url->displayoptions) ? [] : (array) unserialize_array($url->displayoptions); - if ($ignoresettings or !empty($options['printintro'])) { - if (trim(strip_tags($url->intro))) { + if ($ignoresettings || !empty($options['printintro'])) { + if (!html_is_blank($url->intro)) { return format_module_intro('url', $url, $cm->id); } } @@ -255,7 +255,7 @@ EOF; function url_print_workaround($url, $cm, $course) { global $OUTPUT, $PAGE, $USER; - $PAGE->activityheader->set_description(url_get_intro($url, $cm, true)); + $PAGE->activityheader->set_description(url_get_intro($url, $cm)); url_print_header($url, $cm, $course); $fullurl = new moodle_url(url_get_full_url($url, $cm, $course));