diff --git a/lib/grade/grade_scale.php b/lib/grade/grade_scale.php index 0693037af58..f6fec4bcb27 100644 --- a/lib/grade/grade_scale.php +++ b/lib/grade/grade_scale.php @@ -312,10 +312,10 @@ class grade_scale extends grade_object { /** * Static function returning all global scales * - * @return object + * @return grade_scale[]|false */ public static function fetch_all_global() { - return grade_scale::fetch_all(array('courseid'=>0)); + return grade_scale::fetch_all(['courseid' => 0]); } /** diff --git a/mod/assign/settings.php b/mod/assign/settings.php index 8e99ae1de2c..312a008ce7a 100644 --- a/mod/assign/settings.php +++ b/mod/assign/settings.php @@ -177,14 +177,17 @@ if ($ADMIN->fulltree) { ]); $settings->add($setting); - /** @var grade_scale[] $scales */ - $scales = grade_scale::fetch_all_global(); - $choices = ['' => new lang_string('choosedots')]; - foreach ($scales as $scale) { - $choices[$scale->id] = $scale->get_name(); - } $name = new lang_string('defaultgradescale', 'mod_assign'); $description = new lang_string('defaultgradescale_help', 'mod_assign'); + + $choices = ['' => new lang_string('choosedots')]; + $scales = grade_scale::fetch_all_global(); + if ($scales !== false) { + foreach ($scales as $scale) { + $choices[$scale->id] = $scale->get_name(); + } + } + if (count($choices) > 1) { $setting = new admin_setting_configselect('mod_assign/defaultgradescale', $name,