From e5752b7d5bd54f4269ca7ade8830f4a6df18dffa Mon Sep 17 00:00:00 2001
From: jerome mouneyrac <jerome@moodle.com>
Date: Fri, 5 Feb 2010 06:30:47 +0000
Subject: [PATCH] webservice MDL-21511 display debug info when the exception
 return is invalid parameter type

---
 lib/externallib.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/externallib.php b/lib/externallib.php
index 055a8cd2bc2..8a8182ccf33 100644
--- a/lib/externallib.php
+++ b/lib/externallib.php
@@ -164,7 +164,7 @@ class external_api {
             foreach ($description->keys as $key=>$subdesc) {
                 if (!array_key_exists($key, $params)) {
                     if ($subdesc->required == VALUE_REQUIRED) {
-                        throw new invalid_parameter_exception('Missing required key in single structure.');
+                        throw new invalid_parameter_exception('Missing required key in single structure: '.$key);
                     }
                     if ($subdesc instanceof external_value) {
                             if ($subdesc->required == VALUE_DEFAULT) {
@@ -179,7 +179,8 @@ class external_api {
                     try {
                         $result[$key] = self::validate_parameters($subdesc, $params[$key]);
                     } catch (invalid_parameter_exception $e) {
-                        throw new webservice_parameter_exception('invalidextparam',$key);
+                        //it's ok to display debug info as here the information is useful for ws client/dev
+                        throw new webservice_parameter_exception('invalidextparam',$key." (".$e->debuginfo.")");
                     }
                 }
                 unset($params[$key]);