L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-28129 two issues with loading and saving questions

Browse Source 
1. Missing order by could randomise the order of the hints.

2. the extraanswerfields big had some SQL errros.
This commit is contained in:
Jamie Pratt
2011-06-30 17:21:37 +01:00
committed by Tim Hunt
parent 54ae8ed032
commit e5060e2209
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/type/questiontypebase.php
+4 -3
View File
@@ -493,7 +493,8 @@ class question_type {
global $DB;
$context = $formdata->context;
$oldhints = $DB->get_records('question_hints', array('questionid' => $formdata->id));
$oldhints = $DB->get_records('question_hints',
array('questionid' => $formdata->id), 'id ASC');
if (!empty($formdata->hint)) {
$numhints = max(array_keys($formdata->hint)) + 1;
@@ -628,8 +629,8 @@ class question_type {
$answer_extension_table = array_shift($extraanswerfields);
$question->options->answers = $DB->get_records_sql("
SELECT qa.*, qax." . implode(', qax.', $extraanswerfields) . "
FROM {question_answers} qa, {$answer_extension_table} qax
WHERE qa.questionid = ? AND qax.answerid = qa.id", array($question->id));
FROM {question_answers} qa, {{$answer_extension_table}} qax
WHERE qa.question = ? AND qax.answerid = qa.id", array($question->id));
if (!$question->options->answers) {
echo $OUTPUT->notification('Failed to load question answers from the table ' .
$answer_extension_table . 'for questionid ' . $question->id);