From 12db10be31ec9a71955458065d6b031fd18bba30 Mon Sep 17 00:00:00 2001 From: "info@eWallah.net" Date: Tue, 30 Jan 2024 15:22:53 +0100 Subject: [PATCH 1/2] MDL-80538 phpdoc: Incorrect dataformat type documentation in table lib --- lib/tablelib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/tablelib.php b/lib/tablelib.php index 0bb9343dfa3..89fe0cddc56 100644 --- a/lib/tablelib.php +++ b/lib/tablelib.php @@ -214,10 +214,10 @@ class flexible_table { * for you (even if the param is '', which means no download this time. * Also you can call this method with no params to get the current set * download type. - * @param string $download dataformat type. One of csv, xhtml, ods, etc + * @param string $download type of dataformat for export. * @param string $filename filename for downloads without file extension. * @param string $sheettitle title for downloaded data. - * @return string download dataformat type. One of csv, xhtml, ods, etc + * @return string download dataformat type. */ function is_downloading($download = null, $filename='', $sheettitle='') { if ($download!==null) { From 54608ed959ef82f0fd736885702935d348612a36 Mon Sep 17 00:00:00 2001 From: Simey Lameze Date: Thu, 1 Feb 2024 12:06:43 +0800 Subject: [PATCH 2/2] MDL-80538 phpdoc: add missing null parameter type to phpdoc --- lib/tablelib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tablelib.php b/lib/tablelib.php index 89fe0cddc56..8409b5972c8 100644 --- a/lib/tablelib.php +++ b/lib/tablelib.php @@ -214,7 +214,7 @@ class flexible_table { * for you (even if the param is '', which means no download this time. * Also you can call this method with no params to get the current set * download type. - * @param string $download type of dataformat for export. + * @param string|null $download type of dataformat for export. * @param string $filename filename for downloads without file extension. * @param string $sheettitle title for downloaded data. * @return string download dataformat type.