From e40c5d4def557ea5abb45775d7aef59596ff6292 Mon Sep 17 00:00:00 2001 From: nicolasconnault Date: Fri, 24 Apr 2009 07:49:30 +0000 Subject: [PATCH] MDL-18949 Move selector is now disabled unless at least one grade item is selected. --- grade/edit/tree/functions.js | 17 +++++++++++++++++ grade/edit/tree/index.php | 2 +- grade/edit/tree/lib.php | 2 +- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/grade/edit/tree/functions.js b/grade/edit/tree/functions.js index 9ef91b36167..44835cc4ed1 100755 --- a/grade/edit/tree/functions.js +++ b/grade/edit/tree/functions.js @@ -12,6 +12,8 @@ function togglecheckboxes(eid, value) { } } + toggleCategorySelector(); + } function toggle_advanced_columns() { @@ -26,3 +28,18 @@ function toggle_advanced_columns() { YAHOO.util.Dom.replaceClass(shownAdvEls[i], "advancedshown", "advanced"); } } + +/** + * Check if any of the grade item checkboxes is ticked. If yes, enable the dropdown. Otherwise, disable it + */ +function toggleCategorySelector() { + var itemboxes = YAHOO.util.Dom.getElementsByClassName('itemselect'); + for (var i = 0; i < itemboxes.length; i++) { + if (itemboxes[i].checked) { + document.getElementById('menumoveafter').disabled = false; + return true; + } + } + document.getElementById('menumoveafter').disabled = 'disabled'; + +} diff --git a/grade/edit/tree/index.php b/grade/edit/tree/index.php index 26d7e5abe03..4a79df69abd 100644 --- a/grade/edit/tree/index.php +++ b/grade/edit/tree/index.php @@ -330,7 +330,7 @@ if (!$moving) { echo ''; echo get_string('moveselectedto', 'grades') . ' '; echo choose_from_menu($categories, 'moveafter', '', 'choose', - 'document.getElementById(\'bulkmoveinput\').value=1;document.getElementById(\'gradetreeform\').submit()', 0, true); + 'document.getElementById(\'bulkmoveinput\').value=1;document.getElementById(\'gradetreeform\').submit()', 0, true, true); echo '
diff --git a/grade/edit/tree/lib.php b/grade/edit/tree/lib.php index 7ebdd820237..2ff1dca05b4 100755 --- a/grade/edit/tree/lib.php +++ b/grade/edit/tree/lib.php @@ -952,7 +952,7 @@ class grade_edit_tree_column_select extends grade_edit_tree_column { $itemselect = ''; if ($params['itemtype'] != 'course' && $params['itemtype'] != 'category') { - $itemselect = ''; + $itemselect = ''; } return '' . $itemselect . ''; }