From e3810d112a2eb24db6a94bb1a44e10b3e919a4e2 Mon Sep 17 00:00:00 2001 From: Tomasz Muras Date: Thu, 20 Sep 2012 17:48:14 +0200 Subject: [PATCH] MDL-35547 Detect question category pointing to itself as a parent. --- lib/questionlib.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/questionlib.php b/lib/questionlib.php index 7298d75c34e..910657cf67f 100644 --- a/lib/questionlib.php +++ b/lib/questionlib.php @@ -1184,6 +1184,10 @@ function question_categorylist($categoryid) { $categorylist = array($categoryid); foreach ($subcategories as $subcategory) { + if($subcategory->id == $categoryid) + //prevent infinite loop + throw new coding_exception("Question category $categoryid points to itself as a parent."); + } $categorylist = array_merge($categorylist, question_categorylist($subcategory->id)); }