L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-80087 Questions: warn if preload_all_step_users was not called

Browse Source 
Co-authored-by: Tim Hunt <[email protected]>
This commit is contained in:
Philipp Imhof
2024-03-15 19:41:04 +01:00
co-authored by Tim Hunt
parent 45ad566de9
commit e35eb6b9eb
6 changed files with 39 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/engine/tests/helpers.php
+10 -6
View File
@@ -791,11 +791,13 @@ class question_no_pattern_expectation {
abstract class qbehaviour_walkthrough_test_base extends question_testcase {
/** @var question_display_options */
protected $displayoptions;
/** @var question_usage_by_activity */
protected $quba;
/** @var integer */
/** @var int The slot number of the question_attempt we are using in $quba. */
protected $slot;
/**
* @var string after {@link render()} has been called, this contains the
* display of the question in its current state.
@@ -804,7 +806,8 @@ abstract class qbehaviour_walkthrough_test_base extends question_testcase {
protected function setUp(): void {
parent::setUp();
$this->resetAfterTest(true);
$this->resetAfterTest();
$this->setAdminUser();
$this->displayoptions = new question_display_options();
$this->quba = question_engine::make_questions_usage_by_activity('unit_test',
@@ -914,6 +917,7 @@ abstract class qbehaviour_walkthrough_test_base extends question_testcase {
* $this->currentoutput so that it can be verified.
*/
protected function render() {
$this->quba->preload_all_step_users();
$this->currentoutput = $this->quba->render_question($this->slot, $this->displayoptions);
}
@@ -1005,9 +1009,9 @@ abstract class qbehaviour_walkthrough_test_base extends question_testcase {
* @param $condition one or more Expectations. (users varargs).
*/
protected function check_current_output() {
$html = $this->quba->render_question($this->slot, $this->displayoptions);
$this->render();
foreach (func_get_args() as $condition) {
$this->assert($condition, $html);
$this->assert($condition, $this->currentoutput);
}
}
@@ -1019,9 +1023,9 @@ abstract class qbehaviour_walkthrough_test_base extends question_testcase {
* @param question_contains_select_expectation $expectations One or more expectations.
*/
protected function check_output_contains_selectoptions(...$expectations) {
$html = $this->quba->render_question($this->slot, $this->displayoptions);
$this->render();
foreach ($expectations as $expectation) {
$this->assert_select_options($expectation, $html);
$this->assert_select_options($expectation, $this->currentoutput);
}
}