diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php index 27732f79a4e..7dbc49feef9 100644 --- a/lib/db/upgrade.php +++ b/lib/db/upgrade.php @@ -3090,5 +3090,22 @@ function xmldb_main_upgrade($oldversion) { upgrade_main_savepoint(true, 2018120305.04); } + if ($oldversion < 2018120305.13) { + // Delete "orphaned" subscriptions. + $sql = "SELECT DISTINCT es.userid + FROM {event_subscriptions} es + LEFT JOIN {user} u ON u.id = es.userid + WHERE u.deleted = 1 OR u.id IS NULL"; + $deletedusers = $DB->get_field_sql($sql); + if ($deletedusers) { + list($sql, $params) = $DB->get_in_or_equal($deletedusers); + + // Delete orphaned subscriptions. + $DB->execute("DELETE FROM {event_subscriptions} WHERE userid " . $sql, $params); + } + + upgrade_main_savepoint(true, 2018120305.13); + } + return true; } diff --git a/lib/moodlelib.php b/lib/moodlelib.php index e2016a8bf75..946231f1c11 100644 --- a/lib/moodlelib.php +++ b/lib/moodlelib.php @@ -4182,6 +4182,9 @@ function delete_user(stdClass $user) { // Now do a brute force cleanup. + // Remove user's calendar subscriptions. + $DB->delete_records('event_subscriptions', ['userid' => $user->id]); + // Remove from all cohorts. $DB->delete_records('cohort_members', array('userid' => $user->id)); diff --git a/version.php b/version.php index cc1309a80a2..53cfae6a044 100644 --- a/version.php +++ b/version.php @@ -29,7 +29,7 @@ defined('MOODLE_INTERNAL') || die(); -$version = 2018120305.12; // 20181203 = branching date YYYYMMDD - do not modify! +$version = 2018120305.13; // 20181203 = branching date YYYYMMDD - do not modify! // RR = release increments - 00 in DEV branches. // .XX = incremental changes.