From d6650b63bf9d49066f77af2640ae2ba25b45bdfa Mon Sep 17 00:00:00 2001 From: Angelia Dela Cruz Date: Fri, 17 Nov 2023 15:53:00 +0800 Subject: [PATCH 1/2] MDL-73639 core_grades: Behat to test Recover grades default settings --- .../behat/grade_recovery_settings.feature | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 grade/tests/behat/grade_recovery_settings.feature diff --git a/grade/tests/behat/grade_recovery_settings.feature b/grade/tests/behat/grade_recovery_settings.feature new file mode 100644 index 00000000000..dc9949ec10d --- /dev/null +++ b/grade/tests/behat/grade_recovery_settings.feature @@ -0,0 +1,54 @@ +@core @core_grades @javascript +Feature: Admin can set Recover grades default setting + In order to recover grade + As an admin + I need to enable "Recover grades default" from site administration + + Background: + Given the following "courses" exist: + | fullname | shortname | + | Course 1 | C1 | + And the following "users" exist: + | username | firstname | lastname | email | + | student1 | Student | One | student1@example.com | + And the following "course enrolments" exist: + | user | course | role | + | student1 | C1 | student | + And the following "activities" exist: + | activity | course | name | + | assign | C1 | Assign 1 | + + Scenario Outline: Recover grades default setting can be changed + Given I log in as "admin" + # Set Recover grades default value + And I set the following administration settings values: + | recovergradesdefault | | + # Grade student 1 via quick grading + And I am on the "Assign 1" "assign activity" page + And I follow "View all submissions" + And I click on "Quick grading" "checkbox" + And I set the field "User grade" to "60.00" + And I press "Save all quick grading changes" + # Confirm that assigned grade was saved + And I am on the "Course 1" course page + And I navigate to "View > Grader report" in the course gradebook + And I should see "60.00" in the "Student One" "table_row" + And I navigate to course participants + And I click on "Unenrol" "icon" in the "Student One" "table_row" + And I click on "Unenrol" "button" in the "Unenrol" "dialogue" + And I press "Enrol users" + And I set the field "Select users" to "student1" + # Confirm the "Recover user's old grades if possible" checkbox state based on Recover grades default setting + When I click on "Show more..." "link" + Then the field "Recover user's old grades if possible" matches value "" + # Confirm that "Recover user's old grades if possible" checkbox state can be changed manually + And I click on "Recover user's old grades if possible" "checkbox" in the "Enrol users" "dialogue" + And I click on "Enrol users" "button" in the "Enrol users" "dialogue" + # Confirm whether re-enrolled student's grade is recovered or not based on student enrolment settings + And I navigate to "View > Grader report" in the course gradebook + And I see "60.00" in the "Student One" "table_row" + + Examples: + | recovergradesetting | oldgraderecover | gradevisibility | + | 0 | 0 | should | + | 1 | 1 | should not | From 8168155e17eafbf5459538f6ce0edb6c5b5fd270 Mon Sep 17 00:00:00 2001 From: Simey Lameze Date: Mon, 8 Jan 2024 12:43:21 +0800 Subject: [PATCH 2/2] MDL-73639 behat: improvements to the new recover grades test --- grade/tests/behat/grade_recovery_settings.feature | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/grade/tests/behat/grade_recovery_settings.feature b/grade/tests/behat/grade_recovery_settings.feature index dc9949ec10d..7a46fc3c054 100644 --- a/grade/tests/behat/grade_recovery_settings.feature +++ b/grade/tests/behat/grade_recovery_settings.feature @@ -1,6 +1,6 @@ @core @core_grades @javascript Feature: Admin can set Recover grades default setting - In order to recover grade + In order to recover grades As an admin I need to enable "Recover grades default" from site administration @@ -19,19 +19,16 @@ Feature: Admin can set Recover grades default setting | assign | C1 | Assign 1 | Scenario Outline: Recover grades default setting can be changed - Given I log in as "admin" - # Set Recover grades default value - And I set the following administration settings values: - | recovergradesdefault | | + Given the following config values are set as admin: + | recovergradesdefault | | # Grade student 1 via quick grading - And I am on the "Assign 1" "assign activity" page + And I am on the "Assign 1" "assign activity" page logged in as admin And I follow "View all submissions" And I click on "Quick grading" "checkbox" And I set the field "User grade" to "60.00" And I press "Save all quick grading changes" # Confirm that assigned grade was saved - And I am on the "Course 1" course page - And I navigate to "View > Grader report" in the course gradebook + And I am on the "Course 1" "grades > Grader report > View" page And I should see "60.00" in the "Student One" "table_row" And I navigate to course participants And I click on "Unenrol" "icon" in the "Student One" "table_row" @@ -45,7 +42,7 @@ Feature: Admin can set Recover grades default setting And I click on "Recover user's old grades if possible" "checkbox" in the "Enrol users" "dialogue" And I click on "Enrol users" "button" in the "Enrol users" "dialogue" # Confirm whether re-enrolled student's grade is recovered or not based on student enrolment settings - And I navigate to "View > Grader report" in the course gradebook + And I am on the "Course 1" "grades > Grader report > View" page And I see "60.00" in the "Student One" "table_row" Examples: