L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-64985 message: add better aria labels to the actions menu

Browse Source 
Add better aria labels to the action menus in messaging, renaming
some labels and declaring it as a menu.
This commit is contained in:
Sara Arjona
2019-04-24 18:04:27 +02:00
parent 0f7c44657e
commit e2d400a136
5 changed files with 60 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
theme/bootstrapbase/templates/core_message/message_drawer_view_conversation_header_content_type_private.mustache
+13 -10
View File
@@ -77,47 +77,50 @@
</a>
</div>
<div class="ml-auto dropdown">
<button class="btn btn-link btn-icon icon-size-3" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
<button id="conversation-actions-menu-button" class="btn btn-link btn-icon icon-size-3" type="button"
data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"
aria-label="{{#str}} conversationactions, core_message {{/str}}" aria-controls="conversation-actions-menu">
{{#pix}} i/moremenu, core {{/pix}}
</button>
<ul class="dropdown-menu pull-right">
<ul id="conversation-actions-menu" class="dropdown-menu pull-right" role="menu"
aria-labelledby="conversation-actions-menu-button">
<li data-action="view-contact">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} info, core_message {{/str}}
</a>
</li>
<li class="{{#isfavourite}}hidden{{/isfavourite}} {{^showfavourite}}hidden{{/showfavourite}}" data-action="confirm-favourite">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} addtofavourites, core_message {{/str}}
</a>
</li>
<li class="{{^isfavourite}}hidden{{/isfavourite}} {{^showfavourite}}hidden{{/showfavourite}}" data-action="confirm-unfavourite">
<a class="dropdown-item " href="#">
<a class="dropdown-item " href="#" role="menuitem">
{{#str}} removefromfavourites, core_message {{/str}}
</a>
</li>
<li class="{{#isblocked}}hidden{{/isblocked}}" data-action="request-block">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} blockuser, core_message {{/str}}
</a>
</li>
<li class="{{^isblocked}}hidden{{/isblocked}}" data-action="request-unblock">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} unblockuser, core_message {{/str}}
</a>
</li>
<li data-action="request-delete-conversation">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} deleteconversation, core_message {{/str}}
</a>
</li>
<li class="{{#iscontact}}hidden{{/iscontact}}" data-action="request-add-contact">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} addtoyourcontacts, core_message {{/str}}
</a>
</li>
<li class="{{^iscontact}}hidden{{/iscontact}}" data-action="request-remove-contact">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} removefromyourcontacts, core_message {{/str}}
</a>
</li>
theme/bootstrapbase/templates/core_message/message_drawer_view_conversation_header_content_type_public.mustache
+8 -5
View File
@@ -70,22 +70,25 @@
</a>
</div>
<div class="ml-auto dropdown">
<button class="btn btn-link btn-icon icon-size-3" type="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
<button id="conversation-actions-menu-button" class="btn btn-link btn-icon icon-size-3" type="button"
data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"
aria-label="{{#str}} conversationactions, core_message {{/str}}" aria-controls="conversation-actions-menu">
{{#pix}} i/moremenu, core {{/pix}}
</button>
<ul class="dropdown-menu pull-right">
<ul id="conversation-actions-menu" class="dropdown-menu pull-right" role="menu"
aria-labelledby="conversation-actions-menu-button">
<li data-action="view-group-info">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} groupinfo, core_message {{/str}}
</a>
</li>
<li class="{{#isfavourite}}hidden{{/isfavourite}}" data-action="confirm-favourite">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} addtofavourites, core_message {{/str}}
</a>
</li>
<li class="{{^isfavourite}}hidden{{/isfavourite}}" data-action="confirm-unfavourite">
<a class="dropdown-item" href="#">
<a class="dropdown-item" href="#" role="menuitem">
{{#str}} removefromfavourites, core_message {{/str}}
</a>
</li>