From e29585b206feff5c166e096a124beb7ce807e54a Mon Sep 17 00:00:00 2001
From: Eric Merrill <merrill@oakland.edu>
Date: Wed, 5 Feb 2014 09:56:34 -0500
Subject: [PATCH] MDL-43946 gradebook upgrade Improve SQL to find duplicate
 sortorders.

---
 lib/upgradelib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/upgradelib.php b/lib/upgradelib.php
index b5844a67dd0..05dce3426e4 100644
--- a/lib/upgradelib.php
+++ b/lib/upgradelib.php
@@ -2064,7 +2064,7 @@ function upgrade_grade_item_fix_sortorder() {
 
     $transaction = $DB->start_delegated_transaction();
 
-    $sql = "SELECT g1.id, g1.courseid, g1.sortorder
+    $sql = "SELECT DISTINCT g1.id, g1.courseid, g1.sortorder
               FROM {grade_items} g1
               JOIN {grade_items} g2 ON g1.courseid = g2.courseid
              WHERE g1.sortorder = g2.sortorder AND g1.id != g2.id