MDL-44339 treat unexpected debugging() calls in phpunit tests as errors

2014-03-14 11:47:31 +08:00
parent 2d9a0b8f39
commit e06ec0459f
1 changed files with 4 additions and 1 deletions
@@ -78,8 +78,11 @@ abstract class advanced_testcase extends PHPUnit_Framework_TestCase {
            $DB = phpunit_util::get_global_backup('DB');

            // Deal with any debugging messages.
-            phpunit_util::display_debugging_messages();
+            $debugerror = phpunit_util::display_debugging_messages();
            phpunit_util::reset_debugging();
+            if ($debugerror) {
+                trigger_error('Unenxpected debugging() call detected.', E_USER_NOTICE);
+            }

        } catch (Exception $e) {
            // cleanup after failed expectation