From e01a96ef1598e83503eb416f57f356f0eb40e57b Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Mon, 16 Oct 2006 08:52:52 +0000
Subject: [PATCH] reverting moved $SITE reinitialisation into setting method,
 it was not a good idea after all

---
 admin/settings.php | 3 ++-
 lib/adminlib.php   | 5 +----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/admin/settings.php b/admin/settings.php
index 3c0107d967c..9aec4ca7a44 100644
--- a/admin/settings.php
+++ b/admin/settings.php
@@ -78,7 +78,8 @@ if ($data = data_submitted()) {
     } else {
         error(get_string('confirmsesskeybad', 'error'));
     }
-    //update $COURSE to match changed $SITE
+    // now update $SITE - it might have been changed
+    $SITE = get_record('course', 'id', $SITE->id);
     $COURSE = clone($SITE);
 }
 
diff --git a/lib/adminlib.php b/lib/adminlib.php
index f12edf77391..f5c3cb289df 100644
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -1693,10 +1693,7 @@ class admin_setting_sitesettext extends admin_setting_configtext {
         $record->id = $this->id;
         $record->{$this->name} = $data;
         $record->timemodified = time();
-        $status = update_record('course', $record) ? '' : get_string('errorsetting', 'admin') . $this->visiblename . '<br />';
-        //now update $SITE
-        global $SITE;
-        $SITE = get_record('course', 'id', $SITE->id);
+        return (update_record('course', $record) ? '' : get_string('errorsetting', 'admin') . $this->visiblename . '<br />');
     }
 
 }