MDL-76745 cache: Implement cache_loader_with_locking in cache_disabled

If a plugin attempts to do something that would lock coursemodinfo cache
during install (such as creating a course module), this currently fails
as check_lock_state is not implemented in cache_disabled. Adding the
cache_loader_with_locking interface ensures that all lock methods are
implemented.
This commit is contained in:
Mark Johnson
2023-06-01 15:03:33 +01:00
parent 090baf556e
commit dfdf8ba7c9
2 changed files with 25 additions and 6 deletions
+16 -6
View File
@@ -39,7 +39,7 @@ require_once($CFG->dirroot.'/cache/locallib.php');
* @copyright 2012 Sam Hemelryk
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class cache_disabled extends cache {
class cache_disabled extends cache implements cache_loader_with_locking {
/**
* Constructs the cache.
@@ -204,20 +204,30 @@ class cache_disabled extends cache {
/**
* Pretend that we got a lock to avoid errors.
*
* @param string $key
* @param int|string $key
* @return bool
*/
public function acquire_lock(string $key) : bool {
public function acquire_lock($key) : bool {
return true;
}
/**
* Pretend that we released a lock to avoid errors.
*
* @param string $key
* @return void
* @param int|string $key
* @return bool
*/
public function release_lock(string $key) : bool {
public function release_lock($key) : bool {
return true;
}
/**
* Pretend that we have a lock to avoid errors.
*
* @param int|string $key
* @return bool
*/
public function check_lock_state($key) : bool {
return true;
}
}