From dfae0ffa1bfb410023cc860f938b4dd34ce5ea99 Mon Sep 17 00:00:00 2001
From: toyomoyo <toyomoyo>
Date: Fri, 5 Oct 2007 03:27:23 +0000
Subject: [PATCH] modinstance fed with wrong cmid, thanks shane

---
 mod/forum/post.php | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/mod/forum/post.php b/mod/forum/post.php
index a5760a15e10..20fde437b3c 100644
--- a/mod/forum/post.php
+++ b/mod/forum/post.php
@@ -144,7 +144,8 @@
         }
 
         $coursecontext = get_context_instance(CONTEXT_COURSE, $course->id);
-		$modcontext = get_context_instance(CONTEXT_MODULE, $forum->id);
+		$cm = get_coursemodule_from_instance("forum", $forum->id, $course->id);
+        $modcontext = get_context_instance(CONTEXT_MODULE, $cm->id);
 
         if (! forum_user_can_post($forum)) {
             if (has_capability('moodle/legacy:guest', $coursecontext, NULL, false)) {  // User is a guest here!
@@ -156,19 +157,18 @@
             }
         }
 
-        if ($cm = get_coursemodule_from_instance("forum", $forum->id, $course->id)) {
-            if (groupmode($course, $cm)) {   // Make sure user can post here
-                $mygroupid = mygroupid($course->id);
-                if (!((empty($mygroupid) and $discussion->groupid == -1)
-						|| (ismember($discussion->groupid)/*$mygroupid == $discussion->groupid*/)
-						|| has_capability('moodle/site:accessallgroups', $modcontext, NULL, false) )) {
-                    print_error('nopostdiscussion', 'forum');
-                }
-            }
-            if (!$cm->visible and !has_capability('moodle/course:manageactivities', $coursecontext)) {
-                error(get_string("activityiscurrentlyhidden"));
+        if (groupmode($course, $cm)) {   // Make sure user can post here
+            $mygroupid = mygroupid($course->id);
+            if (!((empty($mygroupid) and $discussion->groupid == -1)
+					|| (ismember($discussion->groupid)/*$mygroupid == $discussion->groupid*/)
+					|| has_capability('moodle/site:accessallgroups', $modcontext, NULL, false) )) {
+                print_error('nopostdiscussion', 'forum');
             }
         }
+        if (!$cm->visible and !has_capability('moodle/course:manageactivities', $coursecontext)) {
+            error(get_string("activityiscurrentlyhidden"));
+        }
+
 
         // Load up the $post variable.