From dfa4dd740afcb487c3f70beb35552f5b5820d51e Mon Sep 17 00:00:00 2001 From: tjhunt Date: Sun, 1 Oct 2006 20:31:47 +0000 Subject: [PATCH] Fix performance problem with lots of categories. http://moodle.org/mod/forum/discuss.php?d=54945#252145 --- question/question.php | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/question/question.php b/question/question.php index ca4320b33ae..7a4b3b34de6 100644 --- a/question/question.php +++ b/question/question.php @@ -261,11 +261,6 @@ $gradeoptions = $creategrades->gradeoptions; $gradeoptionsfull = $creategrades->gradeoptionsfull; - if (!$categories = question_category_menu($course->id, false)) { - error("No categories!"); - } - - make_upload_directory("$course->id"); // Just in case $coursefiles = get_directory_list("$CFG->dataroot/$course->id", $CFG->moddata); foreach ($coursefiles as $filename) { @@ -274,8 +269,7 @@ } } - // Print the question editing form - + // Initialise defaults if necessary. if (empty($question->id)) { $question->id = ""; } @@ -295,7 +289,7 @@ $question->defaultgrade = 1; } - // Set up some Richtext editing if necessary + // Set up some richtext editing if necessary if ($usehtmleditor = can_use_richtext_editor()) { $defaultformat = FORMAT_HTML; } else { @@ -306,6 +300,7 @@ $err = $question->errors; } + // Print the question editing form echo '
'; print_simple_box_start('center'); require_once('type/'.$qtype.'/editquestion.php');