From df82be756ec49fcbdcfdd0f9414c33fa20ff4896 Mon Sep 17 00:00:00 2001 From: ferran Date: Wed, 20 Aug 2025 13:55:25 +0200 Subject: [PATCH] MDL-84632 mod_resource: deprecate index.php related event --- .upgradenotes/MDL-84632-2025082011505355.yml | 7 +++++ .../course_module_instance_list_viewed.php | 26 ++++++++++++------- .../mod/resource/tests/event/events_test.php | 26 ------------------- 3 files changed, 24 insertions(+), 35 deletions(-) create mode 100644 .upgradenotes/MDL-84632-2025082011505355.yml diff --git a/.upgradenotes/MDL-84632-2025082011505355.yml b/.upgradenotes/MDL-84632-2025082011505355.yml new file mode 100644 index 00000000000..b8b7c918b75 --- /dev/null +++ b/.upgradenotes/MDL-84632-2025082011505355.yml @@ -0,0 +1,7 @@ +issueNumber: MDL-84632 +notes: + mod_resource: + - message: >- + The \mod_resource\event\course_module_instance_list_viewed event is now + deprecated. Use \core\event\course_resources_list_viewed instead. + type: deprecated diff --git a/public/mod/resource/classes/event/course_module_instance_list_viewed.php b/public/mod/resource/classes/event/course_module_instance_list_viewed.php index 76d310ec6c4..88986c3b823 100644 --- a/public/mod/resource/classes/event/course_module_instance_list_viewed.php +++ b/public/mod/resource/classes/event/course_module_instance_list_viewed.php @@ -14,14 +14,6 @@ // You should have received a copy of the GNU General Public License // along with Moodle. If not, see . -/** - * The mod_resource instance list viewed event. - * - * @package mod_resource - * @copyright 2014 Rajesh Taneja - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - */ - namespace mod_resource\event; defined('MOODLE_INTERNAL') || die(); @@ -33,7 +25,23 @@ defined('MOODLE_INTERNAL') || die(); * @since Moodle 2.7 * @copyright 2014 Rajesh Taneja * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later + * @deprecated This event is deprecated and will be removed in Moodle 6.0. + * @todo Remove class in 6.0 (MDL-86384) */ +#[\core\attribute\deprecated( + replacement: core\event\course_resources_list_viewed::class, + since: '5.1', + mdl: 'MDL-84632', +)] class course_module_instance_list_viewed extends \core\event\course_module_instance_list_viewed { - // No need for any code here as everything is handled by the parent class. + #[\Override] + #[\core\attribute\deprecated( + replacement: core\event\course_resources_list_viewed::class, + since: '5.1', + mdl: 'MDL-84632', + )] + protected function init() { + \core\deprecation::emit_deprecation([self::class, __FUNCTION__]); + parent::init(); + } } diff --git a/public/mod/resource/tests/event/events_test.php b/public/mod/resource/tests/event/events_test.php index b22b2868be2..d6916bfa589 100644 --- a/public/mod/resource/tests/event/events_test.php +++ b/public/mod/resource/tests/event/events_test.php @@ -44,32 +44,6 @@ final class events_test extends \advanced_testcase { $this->setAdminUser(); } - /** - * Test course_module_instance_list_viewed event. - */ - public function test_course_module_instance_list_viewed(): void { - // There is no proper API to call to trigger this event, so what we are - // doing here is simply making sure that the events returns the right information. - - $course = $this->getDataGenerator()->create_course(); - $params = array( - 'context' => \context_course::instance($course->id) - ); - $event = \mod_resource\event\course_module_instance_list_viewed::create($params); - - // Triggering and capturing the event. - $sink = $this->redirectEvents(); - $event->trigger(); - $events = $sink->get_events(); - $this->assertCount(1, $events); - $event = reset($events); - - // Checking that the event contains the expected values. - $this->assertInstanceOf('\mod_resource\event\course_module_instance_list_viewed', $event); - $this->assertEquals(\context_course::instance($course->id), $event->get_context()); - $this->assertEventContextNotUsed($event); - } - /** * Test course_module_viewed event. */