From df44fd80ff8fb4de6794978b4eadcd1ba88531c8 Mon Sep 17 00:00:00 2001
From: Frederic Massart <fred@moodle.com>
Date: Thu, 6 Nov 2014 15:23:58 +0800
Subject: [PATCH] MDL-46416 group: Use a revision number for group pictures

---
 group/lib.php  | 6 +++---
 lib/weblib.php | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/group/lib.php b/group/lib.php
index 970ce787bb4..83672a09cb7 100644
--- a/group/lib.php
+++ b/group/lib.php
@@ -347,9 +347,9 @@ function groups_update_group_icon($group, $data, $editform) {
 
     //TODO: it would make sense to allow picture deleting too (skodak)
     if ($iconfile = $editform->save_temp_file('imagefile')) {
-        if (process_new_icon($context, 'group', 'icon', $group->id, $iconfile)) {
-            $DB->set_field('groups', 'picture', 1, array('id'=>$group->id));
-            $group->picture = 1;
+        if ($rev = process_new_icon($context, 'group', 'icon', $group->id, $iconfile)) {
+            $DB->set_field('groups', 'picture', $rev, array('id'=>$group->id));
+            $group->picture = $rev;
         } else {
             $fs->delete_area_files($context->id, 'group', 'icon', $group->id);
             $DB->set_field('groups', 'picture', 0, array('id'=>$group->id));
diff --git a/lib/weblib.php b/lib/weblib.php
index ff3a3fff501..1ba1f82a1a5 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -2222,6 +2222,7 @@ function print_group_picture($group, $courseid, $large=false, $return=false, $li
     }
 
     $grouppictureurl = moodle_url::make_pluginfile_url($context->id, 'group', 'icon', $group->id, '/', $file);
+    $grouppictureurl->param('rev', $group->picture);
     $output .= '<img class="grouppicture" src="'.$grouppictureurl.'"'.
         ' alt="'.s(get_string('group').' '.$group->name).'" title="'.s($group->name).'"/>';