From dea5950384a2258ffad9986c6f5926099686aebb Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Wed, 23 Apr 2025 21:11:56 +0100 Subject: [PATCH] MDL-85266 tool_uploaduser: correctly key bulk users session array. --- admin/tool/uploaduser/classes/process.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/admin/tool/uploaduser/classes/process.php b/admin/tool/uploaduser/classes/process.php index 562e5895629..70928dd2bc4 100644 --- a/admin/tool/uploaduser/classes/process.php +++ b/admin/tool/uploaduser/classes/process.php @@ -910,8 +910,8 @@ class process { } if ($this->get_bulk() == UU_BULK_UPDATED or $this->get_bulk() == UU_BULK_ALL) { - if (!in_array($user->id, $SESSION->bulk_users)) { - $SESSION->bulk_users[] = $user->id; + if (!array_key_exists($user->id, $SESSION->bulk_users)) { + $SESSION->bulk_users[$user->id] = $user->id; } } @@ -924,8 +924,8 @@ class process { $this->usersuptodate++; if ($this->get_bulk() == UU_BULK_ALL) { - if (!in_array($user->id, $SESSION->bulk_users)) { - $SESSION->bulk_users[] = $user->id; + if (!array_key_exists($user->id, $SESSION->bulk_users)) { + $SESSION->bulk_users[$user->id] = $user->id; } } } @@ -1059,8 +1059,8 @@ class process { \context_user::instance($user->id); if ($this->get_bulk() == UU_BULK_NEW or $this->get_bulk() == UU_BULK_ALL) { - if (!in_array($user->id, $SESSION->bulk_users)) { - $SESSION->bulk_users[] = $user->id; + if (!array_key_exists($user->id, $SESSION->bulk_users)) { + $SESSION->bulk_users[$user->id] = $user->id; } } }