From dcb8f5fefb4391ffa4d7d83803a04ec9c033ce18 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Thu, 27 Jun 2019 00:01:43 +0200 Subject: [PATCH] MDL-53778 quiz: ensure completion deps are fulfilled by generator uses There are some mod_quiz generator issues where the new chain of dependencies between completion settings was not being observed. This patch just ensures that the now 3 chained settings are enabled together (or new quiz options logic will proceed to disable them). --- mod/quiz/tests/lib_test.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mod/quiz/tests/lib_test.php b/mod/quiz/tests/lib_test.php index bf822270a12..df77dee1286 100644 --- a/mod/quiz/tests/lib_test.php +++ b/mod/quiz/tests/lib_test.php @@ -166,6 +166,7 @@ class mod_quiz_lib_testcase extends advanced_testcase { 'questionsperpage' => 0, 'sumgrades' => 1, 'completion' => COMPLETION_TRACKING_AUTOMATIC, + 'completionusegrade' => 1, 'completionpass' => 1); $quiz = $quizgenerator->create_instance($data); $cm = get_coursemodule_from_id('quiz', $quiz->cmid); @@ -880,14 +881,14 @@ class mod_quiz_lib_testcase extends advanced_testcase { $quiz1 = $this->getDataGenerator()->create_module('quiz', [ 'course' => $course->id, 'completion' => 2, + 'completionusegrade' => 1, 'completionattemptsexhausted' => 1, 'completionpass' => 1 ]); $quiz2 = $this->getDataGenerator()->create_module('quiz', [ 'course' => $course->id, 'completion' => 2, - 'completionattemptsexhausted' => 0, - 'completionpass' => 0 + 'completionusegrade' => 0 ]); $cm1 = cm_info::create(get_coursemodule_from_instance('quiz', $quiz1->id)); $cm2 = cm_info::create(get_coursemodule_from_instance('quiz', $quiz2->id));