diff --git a/mod/data/lib.php b/mod/data/lib.php index f0a89b9cc78..1b3a9e86f58 100755 --- a/mod/data/lib.php +++ b/mod/data/lib.php @@ -2070,10 +2070,11 @@ class PresetImporter { // existing valuas MUST be sent too - it can not work without them! foreach ($this->data as $prop=>$unused) { - if (array_key_exists($prop, $settings)) { - $this->$prop = $settings->$prop; + if (array_key_exists($prop, (array)$settings)) { + $this->data->$prop = $settings->$prop; } } + data_update_instance(addslashes_object($this->data)); if (strstr($this->folder, '/temp/')) clean_preset($this->folder); /* Removes the temporary files */ diff --git a/mod/data/preset.php b/mod/data/preset.php index 334be156acd..3f4bac95840 100644 --- a/mod/data/preset.php +++ b/mod/data/preset.php @@ -10,7 +10,6 @@ require_once('lib.php'); require_once($CFG->libdir.'/uploadlib.php'); require_once($CFG->libdir.'/xmlize.php'); - $id = optional_param('id', 0, PARAM_INT); // course module id $d = optional_param('d', 0, PARAM_INT); // database activity id $action = optional_param('action', 'base', PARAM_ALPHANUM); // current action @@ -203,8 +202,6 @@ switch ($action) { echo ''; break; - - /***************** Exporting *****************/ case 'save1': if (!data_submitted() or !confirm_sesskey()) { @@ -319,25 +316,20 @@ $options->d = $data->id; $options->sesskey = sesskey(); print_single_button('preset.php', $options, $strsave, 'post'); echo ''; - - echo '