L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-47832 cache: removed data source aggregate functionality

Browse Source 
Cache data source aggregate functionality was found to be broken
and unused, because of this the decision was made to remove it
rather than fix it.
As it was broken we did not follow typical deprecation methods and
instead the code was removed outright with only structure
remaining and left deprecated.
This commit is contained in:
Sam Hemelryk
2014-11-20 11:26:10 +13:00
parent 0ac6d59990
commit da983ee1c5
6 changed files with 32 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cache/disabledlib.php
Vendored
+5 -5
View File
@@ -184,10 +184,10 @@ class cache_factory_disabled extends cache_factory {
*
* @param string $component
* @param string $area
* @param string $aggregate Unused.
* @param string $unused Used to be datasourceaggregate but that was removed and this is now unused.
* @return cache_definition
*/
public function create_definition($component, $area, $aggregate = null) {
public function create_definition($component, $area, $unused = null) {
return cache_definition::load_adhoc(cache_store::MODE_REQUEST, $component, $area);
}
@@ -208,11 +208,11 @@ class cache_factory_disabled extends cache_factory {
* @param string $component
* @param string $area
* @param array $identifiers
* @param string $aggregate
* @param string $unused Used to be datasourceaggregate but that was removed and this is now unused.
* @return cache_application|cache_session|cache_request
*/
public function create_cache_from_definition($component, $area, array $identifiers = array(), $aggregate = null) {
$definition = $this->create_definition($component, $area, $aggregate);
public function create_cache_from_definition($component, $area, array $identifiers = array(), $unused = null) {
$definition = $this->create_definition($component, $area);
$cache = $this->create_cache($definition, $identifiers);
return $cache;
}