MDL-28268 Missing ORDER BY when using extra answer table.
From OU bug #921 "Order of answer fields in Variable numeric keeps changing" Cannot reproduce this bug on my system but hopefully this will fix the problem. I added an ORDER BY clause to the sql for fetching answers with extra answer fields.
This commit is contained in:
@@ -630,7 +630,8 @@ class question_type {
|
||||
$question->options->answers = $DB->get_records_sql("
|
||||
SELECT qa.*, qax." . implode(', qax.', $extraanswerfields) . "
|
||||
FROM {question_answers} qa, {{$answer_extension_table}} qax
|
||||
WHERE qa.question = ? AND qax.answerid = qa.id", array($question->id));
|
||||
WHERE qa.question = ? AND qax.answerid = qa.id
|
||||
ORDER BY qa.id", array($question->id));
|
||||
if (!$question->options->answers) {
|
||||
echo $OUTPUT->notification('Failed to load question answers from the table ' .
|
||||
$answer_extension_table . 'for questionid ' . $question->id);
|
||||
|
||||
Reference in New Issue
Block a user