From da78b10ce0ff1104c3ce2dff6fd63bce0f166042 Mon Sep 17 00:00:00 2001
From: Dongsheng Cai <dongsheng@moodle.com>
Date: Mon, 2 May 2011 16:39:29 +0800
Subject: [PATCH] MDL-27341, fixed flickr public plugin should check search
 text, tag and nsid before searching photos

---
 repository/flickr_public/lib.php | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/repository/flickr_public/lib.php b/repository/flickr_public/lib.php
index 36910d3d975..62a2907c155 100644
--- a/repository/flickr_public/lib.php
+++ b/repository/flickr_public/lib.php
@@ -280,19 +280,19 @@ class repository_flickr_public extends repository {
 
         $licenses = implode(',', $licenses);
 
-        if (!empty($SESSION->{$this->sess_tag})         // use tag to search
-            or !empty($SESSION->{$this->sess_text})     // use keyword to search
-            or !empty($this->nsid)/*use pre-defined accound*/) {
-            $photos = $this->flickr->photos_search(array(
-                'tags'=>$SESSION->{$this->sess_tag},
-                'page'=>$page,
-                'per_page'=>24,
-                'user_id'=>$this->nsid,
-                'license'=>$licenses,
-                'text'=>$SESSION->{$this->sess_text}
-                )
-            );
-        }
+        $tag  = !empty($SESSION->{$this->sess_tag})  ? $SESSION->{$this->sess_tag}  : null;
+        $text = !empty($SESSION->{$this->sess_text}) ? $SESSION->{$this->sess_text} : null;
+        $nsid = !empty($this->nsid) ? $this->nsid : null;
+
+        $photos = $this->flickr->photos_search(array(
+            'tags'=>$tag,
+            'page'=>$page,
+            'per_page'=>24,
+            'user_id'=>$nsid,
+            'license'=>$licenses,
+            'text'=>$text
+            )
+        );
         $ret['total'] = $photos['total'];
         $ret['perpage'] = $photos['perpage'];
         if (empty($photos)) {