From 2d0a11ee947523b16a4ddb480c50d52fbeb4d637 Mon Sep 17 00:00:00 2001 From: Eric Merrill Date: Mon, 20 Aug 2012 17:09:40 -0400 Subject: [PATCH] MDL-34985 gradebook Fixing issue where default parent in Full View Add Category could be inconsistent. Turns out the correct default was already computed, but was not being applied to the setting. --- grade/edit/tree/category_form.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grade/edit/tree/category_form.php b/grade/edit/tree/category_form.php index 5a1d8f7c30e..c155565ffe4 100644 --- a/grade/edit/tree/category_form.php +++ b/grade/edit/tree/category_form.php @@ -225,7 +225,7 @@ class edit_category_form extends moodleform { $mform->addElement('header', 'headerparent', get_string('parentcategory', 'grades')); $options = array(); - $default = ''; + $default = -1; $categories = grade_category::fetch_all(array('courseid'=>$COURSE->id)); foreach ($categories as $cat) { @@ -238,6 +238,7 @@ class edit_category_form extends moodleform { if (count($categories) > 1) { $mform->addElement('select', 'parentcategory', get_string('parentcategory', 'grades'), $options); + $mform->setDefault('parentcategory', $default); $mform->addElement('static', 'currentparentaggregation', get_string('currentparentaggregation', 'grades')); }