From d8e72a6aad4fdaf1a613cc7ad4cdcfc6efd2ae8a Mon Sep 17 00:00:00 2001
From: Simey Lameze <simey@moodle.com>
Date: Wed, 27 Mar 2019 11:04:40 +0800
Subject: [PATCH] MDL-65047 portifolio: delete legacy portfolio_cron() function

---
 lib/portfoliolib.php  | 34 ----------------------------------
 portfolio/upgrade.txt |  4 ++++
 2 files changed, 4 insertions(+), 34 deletions(-)

diff --git a/lib/portfoliolib.php b/lib/portfoliolib.php
index 68fcf860f0a..3f0d66daee5 100644
--- a/lib/portfoliolib.php
+++ b/lib/portfoliolib.php
@@ -930,40 +930,6 @@ function portfolio_report_insane($insane, $instances=false, $return=false) {
     echo $output;
 }
 
-/**
- * Main portfolio cronjob.
- * Currently just cleans up expired transfer records.
- */
-function portfolio_cron() {
-    global $DB, $CFG;
-
-    require_once($CFG->libdir . '/portfolio/exporter.php');
-    if ($expired = $DB->get_records_select('portfolio_tempdata', 'expirytime < ?', array(time()), '', 'id')) {
-        foreach ($expired as $d) {
-            try {
-                $e = portfolio_exporter::rewaken_object($d->id);
-                $e->process_stage_cleanup(true);
-            } catch (Exception $e) {
-                mtrace('Exception thrown in portfolio cron while cleaning up ' . $d->id . ': ' . $e->getMessage());
-            }
-        }
-    }
-
-    $process = $DB->get_records('portfolio_tempdata', array('queued' => 1), 'id ASC', 'id');
-    foreach ($process as $d) {
-        try {
-            $exporter = portfolio_exporter::rewaken_object($d->id);
-            $exporter->process_stage_package();
-            $exporter->process_stage_send();
-            $exporter->save();
-            $exporter->process_stage_cleanup();
-        } catch (Exception $e) {
-            // This will get probably retried in the next cron until it is discarded by the code above.
-            mtrace('Exception thrown in portfolio cron while processing ' . $d->id . ': ' . $e->getMessage());
-        }
-    }
-}
-
 /**
  * Helper function to rethrow a caught portfolio_exception as an export exception.
  * Used because when a portfolio_export exception is thrown the export is cancelled
diff --git a/portfolio/upgrade.txt b/portfolio/upgrade.txt
index 49d49937e6c..eda575d1465 100644
--- a/portfolio/upgrade.txt
+++ b/portfolio/upgrade.txt
@@ -1,6 +1,10 @@
 This files describes API changes in /portfolio/ portfolio system,
 information provided here is intended especially for developers.
 
+=== 3.7 ===
+
+* The portfolio_cron() function has been removed. Please use portfolio_cron_task scheduled task instead.
+
 === 3.1 ===
 
 * The following functions, previously used (exclusively) by upgrade steps are not available