From d79ad5de6a08a1f2f0f71d6de5ed92edcd0bddee Mon Sep 17 00:00:00 2001 From: Marina Glancy Date: Wed, 18 Oct 2023 16:49:10 +0200 Subject: [PATCH] MDL-79761 navigation: fix default setting during web installation --- admin/settings/appearance.php | 4 ++-- lib/moodlelib.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/admin/settings/appearance.php b/admin/settings/appearance.php index 26f3096ade6..4313cc70239 100644 --- a/admin/settings/appearance.php +++ b/admin/settings/appearance.php @@ -200,14 +200,14 @@ reports,core_reportbuilder|/reportbuilder/index.php', )); $choices = [HOMEPAGE_SITE => new lang_string('home')]; - if (!empty($CFG->enabledashboard)) { + if (!isset($CFG->enabledashboard) || $CFG->enabledashboard) { $choices[HOMEPAGE_MY] = new lang_string('mymoodle', 'admin'); } $choices[HOMEPAGE_MYCOURSES] = new lang_string('mycourses', 'admin'); $choices[HOMEPAGE_USER] = new lang_string('userpreference', 'admin'); $temp->add(new admin_setting_configselect('defaulthomepage', new lang_string('defaulthomepage', 'admin'), new lang_string('configdefaulthomepage', 'admin'), get_default_home_page(), $choices)); - if (!empty($CFG->enabledashboard)) { + if (!isset($CFG->enabledashboard) || $CFG->enabledashboard) { $temp->add(new admin_setting_configcheckbox( 'allowguestmymoodle', new lang_string('allowguestmymoodle', 'admin'), diff --git a/lib/moodlelib.php b/lib/moodlelib.php index 76efcfee48d..6f2cebfd8ff 100644 --- a/lib/moodlelib.php +++ b/lib/moodlelib.php @@ -10668,7 +10668,7 @@ function get_home_page() { function get_default_home_page(): int { global $CFG; - return !empty($CFG->enabledashboard) ? HOMEPAGE_MY : HOMEPAGE_MYCOURSES; + return (!isset($CFG->enabledashboard) || $CFG->enabledashboard) ? HOMEPAGE_MY : HOMEPAGE_MYCOURSES; } /**