From d78bd0d23a89d07dd36974158a3fd6fe2d9d5187 Mon Sep 17 00:00:00 2001
From: Laurent David <lmedavid@gmail.com>
Date: Mon, 29 Dec 2025 10:24:59 +0100
Subject: [PATCH] MDL-87304 mod_data: Remove sticky footer other usages

* Remove sticky footer in presets, import, templates and field pages
---
 public/mod/data/lib.php                       |  5 +----
 public/mod/data/renderer.php                  |  5 +----
 .../mod/data/templates/fields_footer.mustache | 11 +++-------
 .../data/templates/preset_preview.mustache    | 20 +++++++-----------
 public/mod/data/templates/presets.mustache    | 21 +++++++------------
 .../data/templates/template_editor.mustache   | 14 +++++--------
 6 files changed, 26 insertions(+), 50 deletions(-)

diff --git a/public/mod/data/lib.php b/public/mod/data/lib.php
index 50aacbf7897..85764133a6e 100644
--- a/public/mod/data/lib.php
+++ b/public/mod/data/lib.php
@@ -463,10 +463,7 @@ class data_field_base {     // Base class for Database Field Types (see field/*/
             'class' => 'btn btn-primary mx-1'
         ]);
         $actionbuttons .= html_writer::end_div();
-
-        $stickyfooter = new core\output\sticky_footer($actionbuttons);
-        echo $OUTPUT->render($stickyfooter);
-
+        echo $actionbuttons;
         echo '</form>';
 
         echo $OUTPUT->box_end();
diff --git a/public/mod/data/renderer.php b/public/mod/data/renderer.php
index ff7f6eb2f94..491daecfd8b 100644
--- a/public/mod/data/renderer.php
+++ b/public/mod/data/renderer.php
@@ -121,10 +121,7 @@ class mod_data_renderer extends plugin_renderer_base {
             'value' => get_string('continue'),
         ]);
         $actionbuttons .= html_writer::end_div();
-
-        $stickyfooter = new core\output\sticky_footer($actionbuttons);
-        $html .= $this->render($stickyfooter);
-
+        $html .= $actionbuttons;
         $html .= html_writer::end_tag('div');
         $html .= html_writer::end_tag('form');
         $html .= html_writer::end_tag('div');
diff --git a/public/mod/data/templates/fields_footer.mustache b/public/mod/data/templates/fields_footer.mustache
index 74f389db2a7..993a8fc366f 100644
--- a/public/mod/data/templates/fields_footer.mustache
+++ b/public/mod/data/templates/fields_footer.mustache
@@ -21,11 +21,6 @@
         "pageurl": "http://yoursite/mod/data/field.php"
     }
 }}
-{{< core/sticky_footer }}
-    {{$ stickyclasses }} justify-content-start{{/ stickyclasses }}
-    {{$ stickycontent }}
-    <div class="ps-3">
-        <a href="{{pageurl}}">{{#str}} viewtemplates, mod_data {{/str}}</a>
-    </div>
-    {{/ stickycontent }}
-{{/ core/sticky_footer }}
+<div class="ps-3">
+    <a href="{{pageurl}}">{{#str}} viewtemplates, mod_data {{/str}}</a>
+</div>
diff --git a/public/mod/data/templates/preset_preview.mustache b/public/mod/data/templates/preset_preview.mustache
index 202e4e5a8c0..4edad3c80e3 100644
--- a/public/mod/data/templates/preset_preview.mustache
+++ b/public/mod/data/templates/preset_preview.mustache
@@ -31,18 +31,14 @@
     {{{preview}}}
     </div>
 </div>
-{{< core/sticky_footer }}
-    {{$ stickycontent }}
-    <form method="post" action="{{formactionurl}}">
-        <input type="hidden" name="cmid" value="{{cmid}}">
-        <input type="hidden" name="mode" value="usepreset">
-        <input type="hidden" name="action" value="select">
-        <input type="hidden" name="fullname" value="{{userid}}/{{shortname}}">
-        <input type="submit" name="selectpreset" data-action="selectpreset" value="{{#str}}usepreset, mod_data{{/str}}" class="btn btn-primary"
-               data-cmid="{{cmid}}" data-presetname="{{userid}}/{{shortname}}">
-    </form>
-    {{/ stickycontent }}
-{{/ core/sticky_footer }}
+<form method="post" action="{{formactionurl}}">
+    <input type="hidden" name="cmid" value="{{cmid}}">
+    <input type="hidden" name="mode" value="usepreset">
+    <input type="hidden" name="action" value="select">
+    <input type="hidden" name="fullname" value="{{userid}}/{{shortname}}">
+    <input type="submit" name="selectpreset" data-action="selectpreset" value="{{#str}}usepreset, mod_data{{/str}}" class="btn btn-primary"
+           data-cmid="{{cmid}}" data-presetname="{{userid}}/{{shortname}}">
+</form>
 
 {{#js}}
     require(['mod_data/importmappingdialogue'], function(importPreset) {
diff --git a/public/mod/data/templates/presets.mustache b/public/mod/data/templates/presets.mustache
index 1aaa7fffab6..5a6fbdb07b6 100644
--- a/public/mod/data/templates/presets.mustache
+++ b/public/mod/data/templates/presets.mustache
@@ -96,19 +96,14 @@
             </tbody>
         </table>
     </fieldset>
-
-    {{< core/sticky_footer }}
-        {{$ stickycontent }}
-            <input
-                type="submit"
-                name="selectpreset"
-                data-action="selectpreset"
-                value="{{#str}}usepreset, mod_data{{/str}}"
-                class="btn btn-secondary"
-                disabled
-            >
-        {{/ stickycontent }}
-    {{/ core/sticky_footer }}
+    <input
+            type="submit"
+            name="selectpreset"
+            data-action="selectpreset"
+            value="{{#str}}usepreset, mod_data{{/str}}"
+            class="btn btn-secondary"
+            disabled
+    >
 </form>
 
 {{#js}}
diff --git a/public/mod/data/templates/template_editor.mustache b/public/mod/data/templates/template_editor.mustache
index 38c2e21ffcf..912addbfd76 100644
--- a/public/mod/data/templates/template_editor.mustache
+++ b/public/mod/data/templates/template_editor.mustache
@@ -110,15 +110,11 @@
         </div>
     </div>
     {{/disableeditor}}
-    {{< core/sticky_footer }}
-        {{$ stickycontent }}
-        <div>
-            <input
-                class="btn btn-primary mx-1"
+    <div>
+        <input
+                class="btn btn-primary mt-2"
                 type="submit"
                 value="{{#str}} save {{/str}}"
-            />
-        </div>
-        {{/ stickycontent }}
-    {{/ core/sticky_footer }}
+        />
+    </div>
 </form>