From d761b3fb191183f1608a6d23450596985c34cfc8 Mon Sep 17 00:00:00 2001
From: sam marshall <s.marshall@open.ac.uk>
Date: Thu, 7 Sep 2017 10:46:58 +0100
Subject: [PATCH] MDL-55356 core_search: API to check if indexing enabled

New function \core_search\manager::is_indexing_enabled(), analagous
to existing is_global_search_enabled().

This replaces existing duplicated code, ready for more use in
following commits.
---
 lib/classes/task/search_index_task.php    |  3 +--
 lib/classes/task/search_optimize_task.php |  3 +--
 search/classes/manager.php                | 11 +++++++++++
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/lib/classes/task/search_index_task.php b/lib/classes/task/search_index_task.php
index 870c4dc24f8..7b6f8011d6a 100644
--- a/lib/classes/task/search_index_task.php
+++ b/lib/classes/task/search_index_task.php
@@ -46,8 +46,7 @@ class search_index_task extends scheduled_task {
      * Throw exceptions on errors (the job will be retried).
      */
     public function execute() {
-        if (!\core_search\manager::is_global_search_enabled() &&
-                !get_config('core', 'searchindexwhendisabled')) {
+        if (!\core_search\manager::is_indexing_enabled()) {
             return;
         }
         $globalsearch = \core_search\manager::instance();
diff --git a/lib/classes/task/search_optimize_task.php b/lib/classes/task/search_optimize_task.php
index 1a006c7dde5..0c55179b017 100644
--- a/lib/classes/task/search_optimize_task.php
+++ b/lib/classes/task/search_optimize_task.php
@@ -49,8 +49,7 @@ class search_optimize_task extends scheduled_task {
      * Throw exceptions on errors (the job will be retried).
      */
     public function execute() {
-        if (!\core_search\manager::is_global_search_enabled() &&
-                !get_config('core', 'searchindexwhendisabled')) {
+        if (!\core_search\manager::is_indexing_enabled()) {
             return;
         }
 
diff --git a/search/classes/manager.php b/search/classes/manager.php
index 3e8daac9d8e..c8425a157c5 100644
--- a/search/classes/manager.php
+++ b/search/classes/manager.php
@@ -157,6 +157,17 @@ class manager {
         return !empty($CFG->enableglobalsearch);
     }
 
+    /**
+     * Returns whether indexing is enabled or not (you can enable indexing even when search is not
+     * enabled at the moment, so as to have it ready for students).
+     *
+     * @return bool True if indexing is enabled.
+     */
+    public static function is_indexing_enabled() {
+        global $CFG;
+        return !empty($CFG->enableglobalsearch) || !empty($CFG->searchindexwhendisabled);
+    }
+
     /**
      * Returns an instance of the search engine.
      *