From 72f7cc6a07bbc1e09137cf18567ad35d3e3f9a8e Mon Sep 17 00:00:00 2001 From: Juan Leyva Date: Tue, 25 Apr 2017 14:34:11 +0200 Subject: [PATCH] MDL-58707 mod_assign: Fix param type for returned field MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The ‘description’ field is populated via a get_string call, this means that it may content html. The component used for translation is also fixed in this commit. --- mod/assign/externallib.php | 2 +- mod/assign/submission/onlinetext/locallib.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/assign/externallib.php b/mod/assign/externallib.php index 41f74c3c3f9..6f3a1af1ee8 100644 --- a/mod/assign/externallib.php +++ b/mod/assign/externallib.php @@ -815,7 +815,7 @@ class mod_assign_external extends external_api { new external_single_structure( array( 'name' => new external_value(PARAM_TEXT, 'field name'), - 'description' => new external_value(PARAM_TEXT, 'field description'), + 'description' => new external_value(PARAM_RAW, 'field description'), 'text' => new external_value (PARAM_RAW, 'field value'), 'format' => new external_format_value ('text') ) diff --git a/mod/assign/submission/onlinetext/locallib.php b/mod/assign/submission/onlinetext/locallib.php index 8cd05284fd2..617b9751864 100644 --- a/mod/assign/submission/onlinetext/locallib.php +++ b/mod/assign/submission/onlinetext/locallib.php @@ -291,7 +291,7 @@ class assign_submission_onlinetext extends assign_submission_plugin { * @return array An array of field names and descriptions. (name=>description, ...) */ public function get_editor_fields() { - return array('onlinetext' => get_string('pluginname', 'assignsubmission_comments')); + return array('onlinetext' => get_string('pluginname', 'assignsubmission_onlinetext')); } /**