diff --git a/blocks/timeline/tests/behat/block_timeline_search.feature b/blocks/timeline/tests/behat/block_timeline_search.feature index f25bbd4cf85..5814ea418a3 100644 --- a/blocks/timeline/tests/behat/block_timeline_search.feature +++ b/blocks/timeline/tests/behat/block_timeline_search.feature @@ -141,7 +141,7 @@ Feature: The timeline block allows users to search for upcoming activities And I should see "Test choice 7" in the ".block-timeline [data-region='view-courses']" "css_element" And I should see "Test choice 8" in the ".block-timeline [data-region='view-courses']" "css_element" When I set the field "Search by activity type or name" to "choice 1" - And I wait until "Course 4" "text" does not exist + And I wait until "//h4[contains(@class, 'h5') and contains(.,'Course 4')]" "xpath_element" does not exist Then I should see "Test choice 1" in the "Timeline" "block" And I should see "Course 2" in the ".block-timeline [data-region='view-courses']" "css_element" And I should not see "Course 1" in the ".block-timeline [data-region='view-courses']" "css_element" diff --git a/calendar/renderer.php b/calendar/renderer.php index 5134fa007fa..3693953d85b 100644 --- a/calendar/renderer.php +++ b/calendar/renderer.php @@ -206,7 +206,7 @@ class core_calendar_renderer extends plugin_renderer_base { } $contextrecords = []; - $courses = calendar_get_default_courses($courseid, 'id, shortname'); + $courses = calendar_get_default_courses($courseid, 'id, fullname'); if (!empty($courses) && count($courses) > CONTEXT_CACHE_MAX_SIZE) { // We need to pull the context records from the DB to preload them @@ -235,7 +235,9 @@ class core_calendar_renderer extends plugin_renderer_base { context_helper::preload_from_record($contextrecords[$course->id]); } $coursecontext = context_course::instance($course->id); - $courseoptions[$course->id] = format_string($course->shortname, true, array('context' => $coursecontext)); + // Limit the displayed course name to prevent the dropdown from getting too wide. + $coursename = shorten_text($course->fullname, 50, true); + $courseoptions[$course->id] = format_string($coursename, true, ['context' => $coursecontext]); } if ($courseid) { @@ -260,7 +262,7 @@ class core_calendar_renderer extends plugin_renderer_base { } $select = html_writer::label($label, $filterid, false, $labelattributes); $select .= html_writer::select($courseoptions, 'course', $selected, false, - ['class' => 'cal_courses_flt ml-1 mr-auto', 'id' => $filterid]); + ['class' => 'cal_courses_flt ml-1 mr-auto mr-2 mb-2', 'id' => $filterid]); return $select; } diff --git a/calendar/templates/add_event_button.mustache b/calendar/templates/add_event_button.mustache index 115e58ce5db..06cdebfd80d 100644 --- a/calendar/templates/add_event_button.mustache +++ b/calendar/templates/add_event_button.mustache @@ -34,7 +34,7 @@ }} {{#defaulteventcontext}} diff --git a/calendar/templates/view_selector.mustache b/calendar/templates/view_selector.mustache index 6a9de4cad1d..a0d5ce36edf 100644 --- a/calendar/templates/view_selector.mustache +++ b/calendar/templates/view_selector.mustache @@ -27,7 +27,7 @@ } }}
-