From d749cbc9a2ceb8f25a735713b869cfeb7c0b4320 Mon Sep 17 00:00:00 2001 From: Brent Boghosian Date: Wed, 6 Mar 2013 16:43:43 +0000 Subject: [PATCH 1/2] MDL-38356 Forms: Check that the form exists before applying changechecker Signed-off-by: Andrew Robert Nicols --- lib/yui/formchangechecker/formchangechecker.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/yui/formchangechecker/formchangechecker.js b/lib/yui/formchangechecker/formchangechecker.js index ea5164d2742..84ffb399459 100644 --- a/lib/yui/formchangechecker/formchangechecker.js +++ b/lib/yui/formchangechecker/formchangechecker.js @@ -17,6 +17,11 @@ YUI.add('moodle-core-formchangechecker', initializer : function(config) { var formid = 'form#' + this.get('formid'); + if (!currentform) { + // If the form was not found, then we can't check for changes. + return; + } + // Add change events to the form elements Y.all(formid + ' input').once('change', M.core_formchangechecker.set_form_changed, this); Y.all(formid + ' textarea').once('change', M.core_formchangechecker.set_form_changed, this); From 10c6db96fb8d1ca5e65568c2be749e477421ecf8 Mon Sep 17 00:00:00 2001 From: Andrew Robert Nicols Date: Wed, 13 Mar 2013 18:15:16 +0000 Subject: [PATCH 2/2] MDL-38356 JavaScript: Correct the test for currentform --- lib/yui/formchangechecker/formchangechecker.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/yui/formchangechecker/formchangechecker.js b/lib/yui/formchangechecker/formchangechecker.js index 84ffb399459..4d78b140be3 100644 --- a/lib/yui/formchangechecker/formchangechecker.js +++ b/lib/yui/formchangechecker/formchangechecker.js @@ -16,9 +16,7 @@ YUI.add('moodle-core-formchangechecker', */ initializer : function(config) { var formid = 'form#' + this.get('formid'); - - if (!currentform) { - // If the form was not found, then we can't check for changes. + if (!Y.one(formid)) { return; }