From d5ed6c36d273d3f84e6902cd2ddd3ed3bc6f2720 Mon Sep 17 00:00:00 2001
From: David Mudrak <david.mudrak@gmail.com>
Date: Thu, 7 Jan 2010 13:53:55 +0000
Subject: [PATCH] MDL-21248 workshop fills description field for a grade
 mapping only element

---
 mod/workshop/assessments.php | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/mod/workshop/assessments.php b/mod/workshop/assessments.php
index 7bb8e974332..15102c573c0 100644
--- a/mod/workshop/assessments.php
+++ b/mod/workshop/assessments.php
@@ -748,9 +748,13 @@
                     $element->maxscore = $themaxscore;
                     if (isset($form->description[$key])) {
                         $element->description   = $form->description[$key];
+                    } else {
+                        $element->description   = '@@ GRADE_MAPPING_ELEMENT @@';
                     }
                     if (isset($form->weight[$key])) {
                         $element->weight = $form->weight[$key];
+                    } else {
+                        $element->weight = 1;
                     }
                     if (!$element->id = insert_record("workshop_elements", $element)) {
                         error("Could not insert workshop element!");
@@ -761,18 +765,20 @@
             case 4: // ...and criteria grading
                 // Insert all the elements that contain something
                 foreach ($form->description as $key => $description) {
-                    unset($element);
-                    $element->workshopid = $workshop->id;
-                    $element->elementno = clean_param($key, PARAM_INT);
-                    $element->description   = $description;
-                    $element->weight = $form->weight[$key];
-                    for ($j=0;$j<5;$j++) {
-                        if (empty($form->rubric[$key][$j]))
-                            break;
-                    }
-                    $element->maxscore = $j - 1;
-                    if (!$element->id = insert_record("workshop_elements", $element)) {
-                        error("Could not insert workshop element!");
+                    if ($description) {
+                        unset($element);
+                        $element->workshopid = $workshop->id;
+                        $element->elementno = clean_param($key, PARAM_INT);
+                        $element->description   = $description;
+                        $element->weight = $form->weight[$key];
+                        for ($j=0;$j<5;$j++) {
+                            if (empty($form->rubric[$key][$j]))
+                                break;
+                        }
+                        $element->maxscore = $j - 1;
+                        if (!$element->id = insert_record("workshop_elements", $element)) {
+                            error("Could not insert workshop element!");
+                        }
                     }
                 }
                 // let's not fool around here, dump the junk!