From abfff66a86e6e02a23947be8d91fa3ba15818528 Mon Sep 17 00:00:00 2001 From: Mihail Geshoski Date: Tue, 26 Sep 2023 15:27:11 +0200 Subject: [PATCH] MDL-79499 gradereport_grader: Pin properly the user name column After modifying the 'overflow-y' css attribute of the #page element in MDL-75762, the user name column is no longer properly pinned. The existing 'top' css attribute on the column cells does not work well with the newly assigned overlow on the #page element and causes the columns to be partially cut off by the page when scrolling horizontally. Re-adjusting the 'top' css attribute to '0' solves this problem. --- theme/boost/scss/moodle/grade.scss | 11 +---------- theme/boost/style/moodle.css | 14 +------------- theme/classic/style/moodle.css | 14 +------------- 3 files changed, 3 insertions(+), 36 deletions(-) diff --git a/theme/boost/scss/moodle/grade.scss b/theme/boost/scss/moodle/grade.scss index 85f543be1cf..ca89cc55708 100644 --- a/theme/boost/scss/moodle/grade.scss +++ b/theme/boost/scss/moodle/grade.scss @@ -635,12 +635,7 @@ } th.header { - @include media-breakpoint-down(sm) { - left: 0; - } - @include media-breakpoint-up(md) { - left: -3rem; - } + left: 0; position: sticky; &#studentheader { @@ -652,10 +647,6 @@ border-right: transparent; } } - - .show-drawer-left .gradeparent th.header { - left: -1rem; - } } /** diff --git a/theme/boost/style/moodle.css b/theme/boost/style/moodle.css index 9ece942406d..1687cdaf26b 100644 --- a/theme/boost/style/moodle.css +++ b/theme/boost/style/moodle.css @@ -35849,27 +35849,15 @@ p.arrow_button { border-top: 1px solid #dee2e6; } .path-grade-report-grader .gradeparent th.header { + left: 0; position: sticky; } -@media (max-width: 767.98px) { - .path-grade-report-grader .gradeparent th.header { - left: 0; - } -} -@media (min-width: 768px) { - .path-grade-report-grader .gradeparent th.header { - left: -3rem; - } -} .path-grade-report-grader .gradeparent th.header#studentheader { z-index: 1; } .path-grade-report-grader .gradeparent td.noborder { border-right: transparent; } -.path-grade-report-grader .show-drawer-left .gradeparent th.header { - left: -1rem; -} /** * User report. diff --git a/theme/classic/style/moodle.css b/theme/classic/style/moodle.css index fb5a4d4a468..20d2a6f0fa3 100644 --- a/theme/classic/style/moodle.css +++ b/theme/classic/style/moodle.css @@ -35849,27 +35849,15 @@ p.arrow_button { border-top: 1px solid #dee2e6; } .path-grade-report-grader .gradeparent th.header { + left: 0; position: sticky; } -@media (max-width: 767.98px) { - .path-grade-report-grader .gradeparent th.header { - left: 0; - } -} -@media (min-width: 768px) { - .path-grade-report-grader .gradeparent th.header { - left: -3rem; - } -} .path-grade-report-grader .gradeparent th.header#studentheader { z-index: 1; } .path-grade-report-grader .gradeparent td.noborder { border-right: transparent; } -.path-grade-report-grader .show-drawer-left .gradeparent th.header { - left: -1rem; -} /** * User report.