From d53cc3da71d9fcd5a98d6e5b172dd99da8f0ee53 Mon Sep 17 00:00:00 2001 From: Tony Butler Date: Fri, 13 Jun 2014 10:36:09 +0100 Subject: [PATCH] MDL-43908 mod_assign: Prevent notifications for unavailable assignments Signed-off-by: Tony Butler Conflicts: mod/assign/locallib.php --- mod/assign/locallib.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php index f82f6dd5a71..2c804e200e3 100644 --- a/mod/assign/locallib.php +++ b/mod/assign/locallib.php @@ -5757,7 +5757,16 @@ class assign { } } $mform->addElement('selectyesno', 'sendstudentnotifications', get_string('sendstudentnotifications', 'assign')); - $mform->setDefault('sendstudentnotifications', 1); + // Get assignment visibility information for student. + $modinfo = get_fast_modinfo($settings->course, $userid); + $cm = $modinfo->get_cm($this->get_course_module()->id); + // Don't allow notification to be sent if student can't access assignment. + if (!$cm->uservisible) { + $mform->setDefault('sendstudentnotifications', 0); + $mform->freeze('sendstudentnotifications'); + } else { + $mform->setDefault('sendstudentnotifications', 1); + } $mform->addElement('hidden', 'action', 'submitgrade'); $mform->setType('action', PARAM_ALPHA);