diff --git a/backup/moodle2/backup_stepslib.php b/backup/moodle2/backup_stepslib.php
index 3578063751f..2667e0344fa 100644
--- a/backup/moodle2/backup_stepslib.php
+++ b/backup/moodle2/backup_stepslib.php
@@ -1096,7 +1096,7 @@ class backup_users_structure_step extends backup_structure_step {
'lastaccess', 'lastlogin', 'currentlogin',
'mailformat', 'maildigest', 'maildisplay', 'htmleditor',
'autosubscribe', 'trackforums', 'timecreated',
- 'timemodified', 'trustbitmask', 'screenreader');
+ 'timemodified', 'trustbitmask');
// Then, the fields potentially needing anonymization
$anonfields = array(
diff --git a/grade/report/grader/lib.php b/grade/report/grader/lib.php
index 3f6681e5454..4f14578e1ff 100644
--- a/grade/report/grader/lib.php
+++ b/grade/report/grader/lib.php
@@ -615,7 +615,6 @@ class grade_report_grader extends grade_report {
$rows = array();
$showuserimage = $this->get_pref('showuserimage');
- $fixedstudents = $this->is_fixed_students();
$strfeedback = $this->get_lang_string("feedback");
$strgrade = $this->get_lang_string('grade');
@@ -1639,7 +1638,7 @@ class grade_report_grader extends grade_report {
*/
public function is_fixed_students() {
global $USER, $CFG;
- return empty($USER->screenreader) && $CFG->grade_report_fixedstudents &&
+ return $CFG->grade_report_fixedstudents &&
(check_browser_version('MSIE', '7.0') ||
check_browser_version('Firefox', '2.0') ||
check_browser_version('Gecko', '2006010100') ||
diff --git a/grade/report/grader/module.js b/grade/report/grader/module.js
index 800f5541c03..0ee92bae4b4 100644
--- a/grade/report/grader/module.js
+++ b/grade/report/grader/module.js
@@ -56,7 +56,7 @@ M.gradereport_grader = {
return;
}
- var content = '
';
+ var content = '
';
content += '
'+properties.username+'
'+properties.itemname+'
';
if (properties.feedback) {
content += '
'+properties.feedback+'
';
@@ -241,6 +241,7 @@ M.gradereport_grader.classes.report.prototype.get_cell_info = function(arg) {
}
return {
+ id : cell.getAttribute('id'),
userid : userid,
username : this.users[userid],
itemid : itemid,
diff --git a/lang/en/moodle.php b/lang/en/moodle.php
index ba2def61b15..a9f4b3ee518 100644
--- a/lang/en/moodle.php
+++ b/lang/en/moodle.php
@@ -1466,10 +1466,6 @@ $string['scalestandard_help'] = 'A standard scale is available site-wide, for al
$string['scalestandard_link'] = 'grade/scale';
$string['scalestip'] = 'To create custom scales, use the \'Scales...\' link in your course administration menu.';
$string['scalestip2'] = 'To create custom scales, click the Grades link in the course administration menu, then choose Edit, Scales.';
-$string['screenreaderno'] = 'No';
-$string['screenreaderuse'] = 'Screen reader';
-$string['screenreaderyes'] = 'Yes';
-$string['screenreaderuse_help'] = 'If set to yes, a more accessible interface is provided in various places such as chat.';
$string['screenshot'] = 'Screenshot';
$string['search'] = 'Search'; // TODO MDL-34652 rename to searchforums and move to mod_forum
$string['search_help'] = 'For basic searching of one or more words anywhere in the text, just type them separated by spaces. All words longer than two characters are used.
diff --git a/lib/db/install.xml b/lib/db/install.xml
index bcd5920cdf2..a77dc988729 100644
--- a/lib/db/install.xml
+++ b/lib/db/install.xml
@@ -1,5 +1,5 @@
-
@@ -778,8 +778,7 @@
-
-
+
diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index 4fc23fc1b38..61ba44efa5f 100644
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -1206,5 +1206,19 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2012090700.01);
}
+ if ($oldversion < 2012091700.00) {
+
+ // Dropping screenreader field from user.
+ $table = new xmldb_table('user');
+ $field = new xmldb_field('screenreader');
+
+ if ($dbman->field_exists($table, $field)) {
+ $dbman->drop_field($table, $field);
+ }
+
+ // Main savepoint reached.
+ upgrade_main_savepoint(true, 2012091700.00);
+ }
+
return true;
}
diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index 6e078a8ce5e..7e2eebe355c 100644
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -8815,11 +8815,9 @@ function get_browser_version_classes() {
* @return bool True for yes, false for no
*/
function can_use_rotated_text() {
- global $USER;
- return (check_browser_version('MSIE', 9) || check_browser_version('Firefox', 2) ||
+ return check_browser_version('MSIE', 9) || check_browser_version('Firefox', 2) ||
check_browser_version('Chrome', 21) || check_browser_version('Safari', 536.25) ||
- check_browser_version('Opera', 12) || check_browser_version('Safari iOS', 533)) &&
- !$USER->screenreader;
+ check_browser_version('Opera', 12) || check_browser_version('Safari iOS', 533);
}
/**
diff --git a/mod/chat/lib.php b/mod/chat/lib.php
index 9b5698155c5..fa346b99854 100644
--- a/mod/chat/lib.php
+++ b/mod/chat/lib.php
@@ -1203,7 +1203,7 @@ function chat_supports($feature) {
}
function chat_extend_navigation($navigation, $course, $module, $cm) {
- global $CFG, $USER, $PAGE, $OUTPUT;
+ global $CFG;
$currentgroup = groups_get_activity_group($cm, true);
@@ -1219,12 +1219,9 @@ function chat_extend_navigation($navigation, $course, $module, $cm) {
$links = array();
- // If user is using screenreader, display gui_basic gui link only
- if (empty($USER->screenreader)) {
- $url = new moodle_url($target.'gui_'.$CFG->chat_method.'/index.php', $params);
- $action = new popup_action('click', $url, 'chat'.$course->id.$cm->instance.$currentgroup, array('height' => 500, 'width' => 700));
- $links[] = new action_link($url, $strenterchat, $action);
- }
+ $url = new moodle_url($target.'gui_'.$CFG->chat_method.'/index.php', $params);
+ $action = new popup_action('click', $url, 'chat'.$course->id.$cm->instance.$currentgroup, array('height' => 500, 'width' => 700));
+ $links[] = new action_link($url, $strenterchat, $action);
$url = new moodle_url($target.'gui_basic/index.php', $params);
$action = new popup_action('click', $url, 'chat'.$course->id.$cm->instance.$currentgroup, array('height' => 500, 'width' => 700));
diff --git a/mod/chat/view.php b/mod/chat/view.php
index 7567de06a13..4daae972b5f 100644
--- a/mod/chat/view.php
+++ b/mod/chat/view.php
@@ -126,18 +126,12 @@ if (has_capability('mod/chat:chat', $context)) {
echo '';
}
- if (empty($USER->screenreader)) {
- $params['id'] = $chat->id;
- $chattarget = new moodle_url("/mod/chat/gui_$CFG->chat_method/index.php", $params);
- echo '';
- echo $OUTPUT->action_link($chattarget, $strenterchat, new popup_action('click', $chattarget, "chat$course->id$chat->id$groupparam", array('height' => 500, 'width' => 700)));
- echo '
';
- }
+ $params['id'] = $chat->id;
+ $chattarget = new moodle_url("/mod/chat/gui_$CFG->chat_method/index.php", $params);
+ echo '';
+ echo $OUTPUT->action_link($chattarget, $strenterchat, new popup_action('click', $chattarget, "chat$course->id$chat->id$groupparam", array('height' => 500, 'width' => 700)));
+ echo '
';
- // if user is using screen reader, then there is no need to display this link again
- // users with screenreader set, will only see 1 link, to the manual refresh page
- // for better accessibility
- // show frame/js-less alternative
$params['id'] = $chat->id;
$link = new moodle_url('/mod/chat/gui_basic/index.php', $params);
$action = new popup_action('click', $link, "chat{$course->id}{$chat->id}{$groupparam}", array('height' => 500, 'width' => 700));
diff --git a/report/progress/index.php b/report/progress/index.php
index 7a979dc3053..8997c14f0a2 100644
--- a/report/progress/index.php
+++ b/report/progress/index.php
@@ -326,12 +326,13 @@ foreach($activities as $activity) {
if ($csv) {
print $sep.csv_quote(strip_tags($activity->name)).$sep.csv_quote($datetext);
} else {
+ $formattedactivityname = format_string($activity->name, true, array('context' => $context));
print ''.
''.
+ '/view.php?id='.$activity->id.'" title="' . $formattedactivityname . '">'.
' '.
- format_string($activity->name).'';
+ $formattedactivityname.'';
if ($activity->completionexpected) {
print ''.$datetext.' ';
}
diff --git a/user/editlib.php b/user/editlib.php
index d2250fbbfc3..afddd5c4e1b 100644
--- a/user/editlib.php
+++ b/user/editlib.php
@@ -216,13 +216,6 @@ function useredit_shared_definition(&$mform, $editoroptions = null, $filemanager
$mform->setType('htmleditor', PARAM_INT);
}
- $choices = array();
- $choices['0'] = get_string('screenreaderno');
- $choices['1'] = get_string('screenreaderyes');
- $mform->addElement('select', 'screenreader', get_string('screenreaderuse'), $choices);
- $mform->setDefault('screenreader', 0);
- $mform->addHelpButton('screenreader', 'screenreaderuse');
-
$mform->addElement('text', 'city', get_string('city'), 'maxlength="120" size="21"');
$mform->setType('city', PARAM_TEXT);
$mform->addRule('city', $strrequired, 'required', null, 'client');
diff --git a/version.php b/version.php
index a7954241884..40fd7a42366 100644
--- a/version.php
+++ b/version.php
@@ -30,11 +30,11 @@
defined('MOODLE_INTERNAL') || die();
-$version = 2012092000.00; // YYYYMMDD = weekly release date of this DEV branch
+$version = 2012092100.00; // YYYYMMDD = weekly release date of this DEV branch
// RR = release increments - 00 in DEV branches
// .XX = incremental changes
-$release = '2.4dev (Build: 20120920)'; // Human-friendly version name
+$release = '2.4dev (Build: 20120921)'; // Human-friendly version name
$branch = '24'; // this version's branch
$maturity = MATURITY_ALPHA; // this version's maturity level
|