diff --git a/admin/user.php b/admin/user.php index 97f1abba147..ec0620c566f 100644 --- a/admin/user.php +++ b/admin/user.php @@ -177,8 +177,22 @@ $$column = "".$string[$column]."$columnicon"; } - if ($sort == "name") { - $sort = "firstname"; + $override = new stdClass(); + $override->firstname = 'firstname'; + $override->lastname = 'lastname'; + $fullnamelanguage = get_string('fullnamedisplay', '', $override); + if (($CFG->fullnamedisplay == 'firstname lastname') or + ($CFG->fullnamedisplay == 'firstname') or + ($CFG->fullnamedisplay == 'language' and $fullnamelanguage == 'firstname lastname' )) { + $fullnamedisplay = "$firstname / $lastname"; + if ($sort == "name") { // If sort has already been set to something else then ignore. + $sort = "firstname"; + } + } else { // ($CFG->fullnamedisplay == 'language' and $fullnamelanguage == 'lastname firstname'). + $fullnamedisplay = "$lastname / $firstname"; + if ($sort == "name") { // This should give the desired sorting based on fullnamedisplay. + $sort = "lastname"; + } } list($extrasql, $params) = $ufiltering->get_sql_filter(); @@ -231,18 +245,6 @@ $users = $nusers; } - $override = new stdClass(); - $override->firstname = 'firstname'; - $override->lastname = 'lastname'; - $fullnamelanguage = get_string('fullnamedisplay', '', $override); - if (($CFG->fullnamedisplay == 'firstname lastname') or - ($CFG->fullnamedisplay == 'firstname') or - ($CFG->fullnamedisplay == 'language' and $fullnamelanguage == 'firstname lastname' )) { - $fullnamedisplay = "$firstname / $lastname"; - } else { // ($CFG->fullnamedisplay == 'language' and $fullnamelanguage == 'lastname firstname') - $fullnamedisplay = "$lastname / $firstname"; - } - $table = new html_table(); $table->head = array (); $table->align = array();