From d309f3e218047a6917f3fb1f2020bde3645a0b60 Mon Sep 17 00:00:00 2001
From: Frederic Massart <fred@moodle.com>
Date: Thu, 19 May 2016 11:42:15 +0800
Subject: [PATCH] MDL-54542 competency: Really handle false negatives in plans
 to review

---
 competency/classes/api.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/competency/classes/api.php b/competency/classes/api.php
index 004c8de6ef6..b11daa48c7f 100644
--- a/competency/classes/api.php
+++ b/competency/classes/api.php
@@ -2409,11 +2409,11 @@ class api {
         $sql .= " AND p.userid $insql";
         $params += $inparams;
 
-        // Order by last updated, seconded by ID to prevent random ordering.
-        $sql .= " ORDER BY p.timemodified DESC, p.id ASC";
+        // Order by ID just to have some ordering in place.
+        $ordersql = " ORDER BY p.id ASC";
 
         $plans = array();
-        $records = $DB->get_recordset_sql($select . $sql, $params, $skip, $limit);
+        $records = $DB->get_recordset_sql($select . $sql . $ordersql, $params, $skip, $limit);
         foreach ($records as $record) {
             $plan = new plan(0, plan::extract_record($record, 'plan_'));
             $template = null;