L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-36943 Do not notify about already installed updates

Browse Source 
Before this patch, the available_update_checker::cron_notifications()
method accessed the availableupdates property. But for plugins, that property
basically contains the most recent version available. So we were missing
the check against the actual version installed.

The fix was simple - obtain available updates via the available_updates()
method that performs the check.
This commit is contained in:
David Mudrák
2012-12-06 01:50:42 +01:00
committed by Eloy Lafuente (stronk7)
parent e28d5db2ee
commit d2713eff38
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/pluginlib.php
+11 -8
View File
@@ -1254,15 +1254,18 @@ class available_update_checker {
// $componentupdate is a real update with higher version
$notifications[] = $componentupdate;
} else {
// use the plugin_manager to check if the reported $componentchange
// is a real update with higher version. such a real update must be
// present in the 'availableupdates' property of one of the component's
// available_update_info object
// Use the plugin_manager to check if the detected $componentchange
// is a real update with higher version. That is, the $componentchange
// is present in the array of {@link available_update_info} objects
// returned by the plugin's available_updates() method.
list($plugintype, $pluginname) = normalize_component($component);
if (!empty($plugins[$plugintype][$pluginname]->availableupdates)) {
foreach ($plugins[$plugintype][$pluginname]->availableupdates as $availableupdate) {
if ($availableupdate->version == $componentchange['version']) {
$notifications[] = $componentupdate;
if (!empty($plugins[$plugintype][$pluginname])) {
$availableupdates = $plugins[$plugintype][$pluginname]->available_updates();
if (!empty($availableupdates)) {
foreach ($availableupdates as $availableupdate) {
if ($availableupdate->version == $componentchange['version']) {
$notifications[] = $componentupdate;
}
}
}
}