diff --git a/mod/scorm/locallib.php b/mod/scorm/locallib.php index c2a13f7b942..f8ecf4f04f3 100644 --- a/mod/scorm/locallib.php +++ b/mod/scorm/locallib.php @@ -636,8 +636,11 @@ function scorm_get_sco_runtime($scormid, $scoid, $userid, $attempt=1) { global $DB; $timedata = new stdClass(); - $sql = !empty($scoid) ? "userid=$userid AND scormid=$scormid AND scoid=$scoid AND attempt=$attempt" : "userid=$userid AND scormid=$scormid AND attempt=$attempt"; - $tracks = $DB->get_records_select('scorm_scoes_track', "$sql ORDER BY timemodified ASC"); + $params = array('userid' => $userid, 'scormid' => $scormid, 'attempt' => $attempt); + if (!empty($scoid)) { + $params['scoid'] = $scoid; + } + $tracks = $DB->get_records('scorm_scoes_track', $params, "timemodified ASC"); if ($tracks) { $tracks = array_values($tracks); }