diff --git a/mod/assign/feedback/editpdf/ajax.php b/mod/assign/feedback/editpdf/ajax.php index fd9cd4cac06..432bcff4f58 100644 --- a/mod/assign/feedback/editpdf/ajax.php +++ b/mod/assign/feedback/editpdf/ajax.php @@ -125,14 +125,14 @@ if ($action === 'pollconversions') { $annotations = page_editor::get_annotations($grade->id, $index, $draft); $page->annotations = $annotations; $response->pages[] = $page; - - $component = 'assignfeedback_editpdf'; - $filearea = document_services::PAGE_IMAGE_FILEAREA; - $filepath = '/'; - $fs = get_file_storage(); - $files = $fs->get_directory_files($context->id, $component, $filearea, $grade->id, $filepath); - $response->pageready = count($files); } + + $component = 'assignfeedback_editpdf'; + $filearea = document_services::PAGE_IMAGE_FILEAREA; + $filepath = '/'; + $fs = get_file_storage(); + $files = $fs->get_directory_files($context->id, $component, $filearea, $grade->id, $filepath); + $response->pageready = count($files); } echo json_encode($response); diff --git a/mod/assign/feedback/editpdf/classes/document_services.php b/mod/assign/feedback/editpdf/classes/document_services.php index 9c02a10cb51..f417141596a 100644 --- a/mod/assign/feedback/editpdf/classes/document_services.php +++ b/mod/assign/feedback/editpdf/classes/document_services.php @@ -576,7 +576,9 @@ EOD; } } - if (empty($pages)) { + $totalpagesforattempt = self::page_number_for_attempt($assignment, $userid, $attemptnumber, false); + // Here we are comparing the total number of images against the total number of pages from the combined PDF. + if (empty($pages) || count($pages) != $totalpagesforattempt) { if ($readonly) { // This should never happen, there should be a version of the pages available // whenever we are requesting the readonly version.