MDL-67653 questions: prevent the flag flickering as the page loads

2020-01-10 14:28:16 +00:00
parent 8a82f51043
commit d0c48cd693
5 changed files with 18 additions and 10 deletions
@@ -323,21 +323,23 @@ class core_question_renderer extends plugin_renderer_base {
        if ($flagged) {
            $icon = 'i/flagged';
            $alt = get_string('flagged', 'question');
+            $label = get_string('clickunflag', 'question');
        } else {
            $icon = 'i/unflagged';
            $alt = get_string('notflagged', 'question');
+            $label = get_string('clickflag', 'question');
        }
        $attributes = array(
            'src' => $this->image_url($icon),
            'alt' => $alt,
+            'class' => 'questionflagimage',
        );
        if ($id) {
            $attributes['id'] = $id;
        }
        $img = html_writer::empty_tag('img', $attributes);
-        if ($flagged) {
-            $img .= ' ' . get_string('flagged', 'question');
-        }
+        $img .= html_writer::span($label);
+
        return $img;
    }