From 912296ad30729e8c2540abda29b2d53c5a463ae8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pau=20Ferrer=20Oca=C3=B1a?= Date: Tue, 28 Oct 2014 08:34:01 +0100 Subject: [PATCH] MDL-47227 admin: Fix user bulk selection over 1000 --- admin/user/lib.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/admin/user/lib.php b/admin/user/lib.php index 25775cba590..accf4173b3d 100644 --- a/admin/user/lib.php +++ b/admin/user/lib.php @@ -35,12 +35,12 @@ function get_selection_data($ufiltering) { if ($scount) { if ($scount < MAX_BULK_USERS) { - $in = implode(',', $SESSION->bulk_users); + $bulkusers = $SESSION->bulk_users; } else { $bulkusers = array_slice($SESSION->bulk_users, 0, MAX_BULK_USERS, true); - $in = implode(',', $bulkusers); } - $userlist['susers'] = $DB->get_records_select_menu('user', "id IN ($in)", null, 'fullname', 'id,'.$DB->sql_fullname().' AS fullname'); + list($in, $inparams) = $DB->get_in_or_equal($bulkusers); + $userlist['susers'] = $DB->get_records_select_menu('user', "id $in", $inparams, 'fullname', 'id,'.$DB->sql_fullname().' AS fullname'); } return $userlist;