From fd5db65c0bb96c2abacbdbf243dd3ba315608e0e Mon Sep 17 00:00:00 2001
From: Amaia Anabitarte <amaia@moodle.com>
Date: Wed, 29 Mar 2023 18:15:21 +0200
Subject: [PATCH] MDL-77227 roles: Remove extra information for override page

---
 admin/roles/override.php                  |  1 +
 lib/tests/behat/permissionmanager.feature | 25 +++++++++++++++++++++--
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/admin/roles/override.php b/admin/roles/override.php
index 68a02c4a66d..f9d97a3fcbf 100644
--- a/admin/roles/override.php
+++ b/admin/roles/override.php
@@ -90,6 +90,7 @@ $title = get_string('overridepermissionsforrole', 'core_role', $a);
 $currenttab = 'permissions';
 
 $PAGE->set_title($title);
+$PAGE->activityheader->disable();
 $PAGE->navbar->add($straction);
 switch ($context->contextlevel) {
     case CONTEXT_SYSTEM:
diff --git a/lib/tests/behat/permissionmanager.feature b/lib/tests/behat/permissionmanager.feature
index 77841030f38..d8dfecf2bfb 100644
--- a/lib/tests/behat/permissionmanager.feature
+++ b/lib/tests/behat/permissionmanager.feature
@@ -9,8 +9,8 @@ Feature: Override permissions on a context
       | username  | firstname | lastname | email          |
       | teacher1  | Teacher   | 1        | t1@example.com |
     And the following "courses" exist:
-      | fullname  | shortname |
-      | Course 1  | C1        |
+      | fullname  | shortname | enablecompletion |
+      | Course 1  | C1        | 1                |
     And the following "course enrolments" exist:
       | user      | course | role           |
       | teacher1  | C1     | editingteacher |
@@ -46,3 +46,24 @@ Feature: Override permissions on a context
     And I click on "Prohibit" "icon" in the "mod/forum:addnews" "table_row"
     And I press "Student"
     Then "Add announcementsmod/forum:addnews" row "Prohibited" column of "permissions" table should contain "Student"
+
+  Scenario: Dates, completion and description are not shown in permission and override pages
+    Given the following "activity" exists:
+      | course     | C1                        |
+      | activity   | feedback                  |
+      | name       | Test Feedback             |
+      | intro      | Test feedback description |
+      | completion | 1                         |
+      | timeopen   | ##1 Jan 2040 08:00##      |
+    And I am on the "Test Feedback" "feedback activity" page logged in as teacher1
+    And I should see "Test feedback description"
+    And "Mark as done" "button" should exist
+    And I should see "1 January 2040"
+    When I am on the "Test Feedback" "feedback activity permissions" page
+    Then I should not see "Test feedback description"
+    And "Mark as done" "button" should not exist
+    And I should not see "1 January 2040"
+    And I set the field "Advanced role override" to "Student"
+    And I should not see "Test feedback description"
+    And "Mark as done" "button" should not exist
+    And I should not see "1 January 2040"