diff --git a/course/weeks.php b/course/weeks.php index ecc2d09f7c9..9d369d76a9a 100644 --- a/course/weeks.php +++ b/course/weeks.php @@ -189,12 +189,12 @@ } echo ""; - if ($news or $course->showrecent) { + if (!empty($news) or !empty($course->showrecent)) { echo "
Error: Could not insert a new entry to the Moodle log
"; // Don't throw an error } } diff --git a/lib/moodlelib.php b/lib/moodlelib.php index 69290538c05..f99ece13fa3 100644 --- a/lib/moodlelib.php +++ b/lib/moodlelib.php @@ -1143,7 +1143,7 @@ function check_browser_version($brand="MSIE", $version=5.5) { function can_use_richtext_editor() { /// Is the richedit editor enabled? global $USER, $CFG; - if ($USER->htmleditor and $CFG->htmleditor) { + if (!empty($USER->htmleditor) and !empty($CFG->htmleditor)) { return check_browser_version("MSIE", 5.5); } return false; diff --git a/lib/weblib.php b/lib/weblib.php index 8d9c91b9566..c3e422ad52d 100644 --- a/lib/weblib.php +++ b/lib/weblib.php @@ -163,11 +163,11 @@ function match_referer($good_referer = "") { /// good_referer is not specified, use qualified_me as the good_referer global $CFG; - if ($CFG->buggy_referer) { + if (!empty($CFG->buggy_referer)) { return true; } - if ($good_referer == "") { + if (empty($good_referer)) { $good_referer = qualified_me(); } return $good_referer == get_referer(); diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php index 97526afebd1..d31b9ae309f 100644 --- a/mod/assignment/lib.php +++ b/mod/assignment/lib.php @@ -298,7 +298,7 @@ function assignment_print_difference($time) { } function assignment_print_submission($assignment, $user, $submission, $teachers, $grades) { - global $THEME; + global $THEME, $USER; echo "\n