From ce0bb6e8430428d9a057797c1fe521efedd152d5 Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Tue, 16 Feb 2016 13:35:00 +0800 Subject: [PATCH] MDL-53115 mod_lesson: Remove unnecessary @javascript tags --- .../tests/behat/lesson_delete_answers.feature | 6 ++-- .../tests/behat/lesson_edit_cluster.feature | 1 - .../tests/behat/lesson_edit_pages.feature | 6 ++-- .../tests/behat/lesson_essay_question.feature | 1 - .../behat/lesson_informations_at_end.feature | 3 +- .../tests/behat/lesson_navigation.feature | 4 +-- .../lesson_number_of_student_attempts.feature | 6 ++-- .../tests/behat/lesson_progress_bar.feature | 3 +- mod/lesson/tests/behat/lesson_report.feature | 16 +++++----- mod/lesson/tests/behat/lesson_review.feature | 3 +- .../behat/lesson_student_dashboard.feature | 30 +++++-------------- .../tests/behat/lesson_with_clusters.feature | 3 +- .../behat/lesson_with_subcluster.feature | 1 - .../tests/behat/link_to_gradebook.feature | 9 ++---- .../tests/behat/password_protection.feature | 1 - .../tests/behat/teacher_grade_essays.feature | 7 ++--- 16 files changed, 31 insertions(+), 69 deletions(-) diff --git a/mod/lesson/tests/behat/lesson_delete_answers.feature b/mod/lesson/tests/behat/lesson_delete_answers.feature index 0e50764aa8a..610c7e65855 100644 --- a/mod/lesson/tests/behat/lesson_delete_answers.feature +++ b/mod/lesson/tests/behat/lesson_delete_answers.feature @@ -33,7 +33,7 @@ branch table contents | id_answer_editor_1 | Previous page | | id_jumpto_1 | Previous page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "Numerical" And I press "Add a question page" And I set the following fields to these values: @@ -50,7 +50,6 @@ branch table contents And I press "Save page" And I follow "Expanded" - @javascript Scenario: Edit lesson content page Given I click on "//th[normalize-space(.)='First page name']/descendant::a[2]" "xpath_element" When I set the following fields to these values: @@ -74,7 +73,6 @@ branch table contents And I should see "Congratulations - end of lesson reached" And I should see "Your score is 1 (out of 1)." - @javascript Scenario: Edit lesson question page Given I click on "//th[normalize-space(.)='Hardest question ever']/descendant::a[2]" "xpath_element" When I set the following fields to these values: @@ -93,4 +91,4 @@ branch table contents And I press "Submit" And I should not see "Incorrect answer" And I should see "Congratulations - end of lesson reached" - And I should see "Your score is 0 (out of 1)." \ No newline at end of file + And I should see "Your score is 0 (out of 1)." diff --git a/mod/lesson/tests/behat/lesson_edit_cluster.feature b/mod/lesson/tests/behat/lesson_edit_cluster.feature index 67294ac6a35..156d3dc3906 100644 --- a/mod/lesson/tests/behat/lesson_edit_cluster.feature +++ b/mod/lesson/tests/behat/lesson_edit_cluster.feature @@ -71,7 +71,6 @@ Feature: In a lesson activity, teacher can edit a cluster page | id_jumpto_0 | Next page | And I press "Save page" - @javascript Scenario: Edit lesson cluster page Given I click on "//th[normalize-space(.)='Cluster']/descendant::a[2]" "xpath_element" When I set the following fields to these values: diff --git a/mod/lesson/tests/behat/lesson_edit_pages.feature b/mod/lesson/tests/behat/lesson_edit_pages.feature index bd7db5e18c8..0be0e57c9f6 100644 --- a/mod/lesson/tests/behat/lesson_edit_pages.feature +++ b/mod/lesson/tests/behat/lesson_edit_pages.feature @@ -30,7 +30,7 @@ Feature: In a lesson activity, teacher can edit lesson's pages | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -56,7 +56,6 @@ Feature: In a lesson activity, teacher can edit lesson's pages | id_score_1 | 0 | And I press "Save page" - @javascript Scenario: Edit lesson content page Given I click on "//th[normalize-space(.)='Second page name']/descendant::a[2]" "xpath_element" When I set the following fields to these values: @@ -92,7 +91,6 @@ Feature: In a lesson activity, teacher can edit lesson's pages And I should see "Congratulations - end of lesson reached" And I should see "Your score is 1 (out of 1)." - @javascript Scenario: Edit lesson question page Given I click on "//th[normalize-space(.)='Hardest question ever']/descendant::a[2]" "xpath_element" When I set the following fields to these values: @@ -126,4 +124,4 @@ Feature: In a lesson activity, teacher can edit lesson's pages And I should not see "Incorrect answer" And I press "Continue" And I should see "Congratulations - end of lesson reached" - And I should see "Your score is 1 (out of 1)." \ No newline at end of file + And I should see "Your score is 1 (out of 1)." diff --git a/mod/lesson/tests/behat/lesson_essay_question.feature b/mod/lesson/tests/behat/lesson_essay_question.feature index 14b8bedd9db..efb17ed5f70 100644 --- a/mod/lesson/tests/behat/lesson_essay_question.feature +++ b/mod/lesson/tests/behat/lesson_essay_question.feature @@ -3,7 +3,6 @@ Feature: In a lesson activity, teacher can add an essay question As a teacher I need to add an essay question in a lesson and grade student attempts - @javascript Scenario: questions with essay question Given the following "users" exist: | username | firstname | lastname | email | diff --git a/mod/lesson/tests/behat/lesson_informations_at_end.feature b/mod/lesson/tests/behat/lesson_informations_at_end.feature index aa2cc673765..96b249f0c60 100644 --- a/mod/lesson/tests/behat/lesson_informations_at_end.feature +++ b/mod/lesson/tests/behat/lesson_informations_at_end.feature @@ -2,7 +2,6 @@ Feature: In a lesson activity, if custom scoring is not enabled, student should see some informations at the end of lesson: questions answered, correct answers, grade, score - @javascript Scenario: Informations at end of lesson if custom scoring not enabled Given the following "users" exist: | username | firstname | lastname | email | @@ -30,7 +29,7 @@ Feature: In a lesson activity, if custom scoring is not enabled, student should | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "Numerical" And I press "Add a question page" And I set the following fields to these values: diff --git a/mod/lesson/tests/behat/lesson_navigation.feature b/mod/lesson/tests/behat/lesson_navigation.feature index 7ba9166b936..fff10b52c1d 100644 --- a/mod/lesson/tests/behat/lesson_navigation.feature +++ b/mod/lesson/tests/behat/lesson_navigation.feature @@ -20,7 +20,6 @@ Feature: In a lesson activity, students can navigate through a series of pages i And I follow "Course 1" And I turn editing mode on - @javascript Scenario: Student navigation with pages and questions Given I add a "Lesson" to section "1" and I fill the form with: | Name | Test lesson name | @@ -33,7 +32,7 @@ Feature: In a lesson activity, students can navigate through a series of pages i | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -89,7 +88,6 @@ Feature: In a lesson activity, students can navigate through a series of pages i And I should see "Congratulations - end of lesson reached" And I should see "Your score is 0 (out of 1)." - @javascript Scenario: Student reattempts a question until out of attempts Given I add a "Lesson" to section "1" and I fill the form with: | Name | Test lesson name | diff --git a/mod/lesson/tests/behat/lesson_number_of_student_attempts.feature b/mod/lesson/tests/behat/lesson_number_of_student_attempts.feature index 364e317ba42..6d3fb7a0bec 100644 --- a/mod/lesson/tests/behat/lesson_number_of_student_attempts.feature +++ b/mod/lesson/tests/behat/lesson_number_of_student_attempts.feature @@ -22,14 +22,13 @@ Feature: In Dashboard, teacher can see the number of student attempts to lessons And I follow "Course 1" And I turn editing mode on - @javascript Scenario: number of student attempts Given I add a "Lesson" to section "1" And I expand all fieldsets - And I click on "id_deadline_enabled" "checkbox" And I set the following fields to these values: | Name | Test lesson name | | Description | Test lesson description | + | id_deadline_enabled | 1 | | deadline[day] | 1 | | deadline[month] | January | | deadline[year] | 2030 | @@ -51,7 +50,7 @@ Feature: In Dashboard, teacher can see the number of student attempts to lessons | id_response_editor_1 | Wrong | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: @@ -143,5 +142,4 @@ Feature: In Dashboard, teacher can see the number of student attempts to lessons And I log in as "teacher1" When I click on "Dashboard" "link" in the "Navigation" "block" Then I should see "You have lessons that are due" - And I click on ".collapsibleregioncaption" "css_element" And I should see "3 attempts" diff --git a/mod/lesson/tests/behat/lesson_progress_bar.feature b/mod/lesson/tests/behat/lesson_progress_bar.feature index 54aeb1d4e03..9a41e2a6de2 100644 --- a/mod/lesson/tests/behat/lesson_progress_bar.feature +++ b/mod/lesson/tests/behat/lesson_progress_bar.feature @@ -4,7 +4,6 @@ Feature: In a lesson activity, students can see their progress viewing a progres As a teacher I need to add pages and questions with links between them - @javascript Scenario: Student navigation with progress bar Given the following "users" exist: | username | firstname | lastname | email | @@ -32,7 +31,7 @@ Feature: In a lesson activity, students can see their progress viewing a progres | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | diff --git a/mod/lesson/tests/behat/lesson_report.feature b/mod/lesson/tests/behat/lesson_report.feature index 7f44f5c2e59..e061f889333 100644 --- a/mod/lesson/tests/behat/lesson_report.feature +++ b/mod/lesson/tests/behat/lesson_report.feature @@ -27,7 +27,6 @@ Feature: In a lesson activity, teachers can review student attempts And I press "Save and return to course" And I follow "Test lesson name" - @javascript Scenario: View student attempts in a lesson containing both content and question pages Given I follow "Add a content page" And I set the following fields to these values: @@ -36,7 +35,7 @@ Feature: In a lesson activity, teachers can review student attempts | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: @@ -49,7 +48,7 @@ Feature: In a lesson activity, teachers can review student attempts | id_response_editor_1 | Wrong | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: @@ -62,7 +61,7 @@ Feature: In a lesson activity, teachers can review student attempts | id_response_editor_1 | Wrong | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Third page name | | Page contents | Third page contents | @@ -71,7 +70,7 @@ Feature: In a lesson activity, teachers can review student attempts | id_answer_editor_1 | Next page | | id_jumpto_1 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -112,7 +111,6 @@ Feature: In a lesson activity, teachers can review student attempts And I should see "Average score" And I should see "Low score" - @javascript Scenario: View student attempts in a lesson containing only content pages Given I follow "Add a content page" And I set the following fields to these values: @@ -121,7 +119,7 @@ Feature: In a lesson activity, teachers can review student attempts | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Fourth page name | | Page contents | Fourth page contents | @@ -130,7 +128,7 @@ Feature: In a lesson activity, teachers can review student attempts | id_answer_editor_1 | End of lesson | | id_jumpto_1 | End of lesson | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Third page name | | Page contents | Third page contents | @@ -139,7 +137,7 @@ Feature: In a lesson activity, teachers can review student attempts | id_answer_editor_1 | Next page | | id_jumpto_1 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | diff --git a/mod/lesson/tests/behat/lesson_review.feature b/mod/lesson/tests/behat/lesson_review.feature index 7e4bb86b664..c8b447a9f02 100644 --- a/mod/lesson/tests/behat/lesson_review.feature +++ b/mod/lesson/tests/behat/lesson_review.feature @@ -4,7 +4,6 @@ Feature: In a lesson activity, students can review the answers they gave to ques As a student I need to complete a lesson answering all of the questions. - @javascript Scenario: Student answers questions and then reviews them. Given the following "users" exist: | username | firstname | lastname | email | @@ -44,7 +43,7 @@ Feature: In a lesson activity, students can review the answers they gave to ques | id_response_editor_1 | Incorrect answer | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: diff --git a/mod/lesson/tests/behat/lesson_student_dashboard.feature b/mod/lesson/tests/behat/lesson_student_dashboard.feature index a00030e757b..b47f5a5e64e 100644 --- a/mod/lesson/tests/behat/lesson_student_dashboard.feature +++ b/mod/lesson/tests/behat/lesson_student_dashboard.feature @@ -23,7 +23,6 @@ Feature: In Dashboard, a student can see their current status on all lessons wit And I follow "Course 1" And I turn editing mode on - @javascript Scenario: A completed lesson with only questions that allows multiple attempts Given I follow "Test lesson name" And I follow "Add a question page" @@ -39,7 +38,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_response_editor_1 | Wrong | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: @@ -69,10 +68,8 @@ Feature: In Dashboard, a student can see their current status on all lessons wit And I should see "Congratulations - end of lesson reached" When I click on "Dashboard" "link" in the "Navigation" "block" Then I should see "You have lessons that are due" - And I click on ".collapsibleregioncaption" "css_element" And I should see "Completed, You can re-attempt this lesson" - @javascript Scenario: A completed lesson with only questions that does not allow multiple attempts Given I follow "Test lesson name" And I navigate to "Edit settings" node in "Lesson administration" @@ -92,7 +89,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_response_editor_1 | Wrong | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: @@ -123,7 +120,6 @@ Feature: In Dashboard, a student can see their current status on all lessons wit When I click on "Dashboard" "link" in the "Navigation" "block" Then I should not see "You have lessons that are due" - @javascript Scenario: A completed lesson with only content pages that allows multiple attempts Given I follow "Test lesson name" And I follow "Add a content page" @@ -133,7 +129,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -152,10 +148,8 @@ Feature: In Dashboard, a student can see their current status on all lessons wit And I press "End of lesson" When I click on "Dashboard" "link" in the "Navigation" "block" Then I should see "You have lessons that are due" - And I click on ".collapsibleregioncaption" "css_element" And I should see "Completed, You can re-attempt this lesson" - @javascript Scenario: A completed lesson with only content pages that does not allow multiple attempts Given I follow "Test lesson name" And I navigate to "Edit settings" node in "Lesson administration" @@ -169,7 +163,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -189,7 +183,6 @@ Feature: In Dashboard, a student can see their current status on all lessons wit When I click on "Dashboard" "link" in the "Navigation" "block" Then I should not see "You have lessons that are due" - @javascript Scenario: An incomplete lesson with only questions. Given I follow "Test lesson name" And I follow "Add a question page" @@ -205,7 +198,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_response_editor_1 | Wrong | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: @@ -229,10 +222,8 @@ Feature: In Dashboard, a student can see their current status on all lessons wit And I press "Continue" When I click on "Dashboard" "link" in the "Navigation" "block" Then I should see "You have lessons that are due" - And I click on ".collapsibleregioncaption" "css_element" And I should see "Lesson has been started, but not yet completed" - @javascript Scenario: An incomplete lesson with only content pages. Given I follow "Test lesson name" And I follow "Add a content page" @@ -242,7 +233,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -260,10 +251,8 @@ Feature: In Dashboard, a student can see their current status on all lessons wit And I should see "Second page contents" When I click on "Dashboard" "link" in the "Navigation" "block" Then I should see "You have lessons that are due" - And I click on ".collapsibleregioncaption" "css_element" And I should see "Lesson has been started, but not yet completed" - @javascript Scenario: A lesson with only questions that has not been started. Given I follow "Test lesson name" And I follow "Add a question page" @@ -279,7 +268,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_response_editor_1 | Wrong | | id_jumpto_1 | This page | And I press "Save page" - And I set the field "qtype" to "Question" + And I select "Question" from the "qtype" singleselect And I set the field "Select a question type" to "True/false" And I press "Add a question page" And I set the following fields to these values: @@ -296,10 +285,8 @@ Feature: In Dashboard, a student can see their current status on all lessons wit And I log in as "student1" When I click on "Dashboard" "link" in the "Navigation" "block" Then I should see "You have lessons that are due" - And I click on ".collapsibleregioncaption" "css_element" And I should see "No attempts have been made on this lesson" - @javascript Scenario: A lesson with only content pages that has not been started. Given I follow "Test lesson name" And I follow "Add a content page" @@ -309,7 +296,7 @@ Feature: In Dashboard, a student can see their current status on all lessons wit | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -322,7 +309,6 @@ Feature: In Dashboard, a student can see their current status on all lessons wit And I log in as "student1" When I click on "Dashboard" "link" in the "Navigation" "block" Then I should see "You have lessons that are due" - And I click on ".collapsibleregioncaption" "css_element" And I should see "No attempts have been made on this lesson" Scenario: Viewing the status for multiple lessons in multiple courses diff --git a/mod/lesson/tests/behat/lesson_with_clusters.feature b/mod/lesson/tests/behat/lesson_with_clusters.feature index 77c6350df2c..41038589432 100644 --- a/mod/lesson/tests/behat/lesson_with_clusters.feature +++ b/mod/lesson/tests/behat/lesson_with_clusters.feature @@ -20,7 +20,6 @@ Feature: In a lesson activity, students can see questions in random order And I follow "Course 1" And I turn editing mode on - @javascript Scenario: Lesson with two clusters Given I add a "Lesson" to section "1" and I fill the form with: | Name | Lesson with clusters | @@ -33,7 +32,7 @@ Feature: In a lesson activity, students can see questions in random order | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | diff --git a/mod/lesson/tests/behat/lesson_with_subcluster.feature b/mod/lesson/tests/behat/lesson_with_subcluster.feature index 4fac50b2df8..5c3580e9168 100644 --- a/mod/lesson/tests/behat/lesson_with_subcluster.feature +++ b/mod/lesson/tests/behat/lesson_with_subcluster.feature @@ -20,7 +20,6 @@ Feature: In a lesson activity, students can see questions in random order and a And I follow "Course 1" And I turn editing mode on - @javascript Scenario: Lesson with subcluster Given I add a "Lesson" to section "1" and I fill the form with: | Name | Lesson with subcluster | diff --git a/mod/lesson/tests/behat/link_to_gradebook.feature b/mod/lesson/tests/behat/link_to_gradebook.feature index 9349a66242c..d7a4874081a 100644 --- a/mod/lesson/tests/behat/link_to_gradebook.feature +++ b/mod/lesson/tests/behat/link_to_gradebook.feature @@ -30,7 +30,7 @@ Feature: link to gradebook on the end of lesson page | id_answer_editor_0 | Next page | | id_jumpto_0 | Next page | And I press "Save page" - And I set the field "qtype" to "Add a content page" + And I select "Add a content page" from the "qtype" singleselect And I set the following fields to these values: | Page title | Second page name | | Page contents | Second page contents | @@ -40,7 +40,6 @@ Feature: link to gradebook on the end of lesson page | id_jumpto_1 | Next page | And I press "Save page" - @javascript Scenario: Link to gradebook for non practice lesson Given I log out When I log in as "student1" @@ -54,7 +53,6 @@ Feature: link to gradebook on the end of lesson page And I should see "User report - Student 1" And I should see "Test lesson" - @javascript Scenario: No link to gradebook for non graded lesson Given I follow "Test lesson" And I navigate to "Edit settings" node in "Lesson administration" @@ -70,7 +68,6 @@ Feature: link to gradebook on the end of lesson page Then I should see "Congratulations - end of lesson reached" And I should not see "View grades" - @javascript Scenario: No link to gradebook for practice lesson Given I follow "Test lesson" And I navigate to "Edit settings" node in "Lesson administration" @@ -86,7 +83,6 @@ Feature: link to gradebook on the end of lesson page Then I should see "Congratulations - end of lesson reached" And I should not see "View grades" - @javascript Scenario: No link if Show gradebook to student disabled Given I follow "Course 1" And I click on "Edit settings" "link" in the "Administration" "block" @@ -102,7 +98,6 @@ Feature: link to gradebook on the end of lesson page Then I should see "Congratulations - end of lesson reached" And I should not see "View grades" - @javascript Scenario: No link to gradebook if no gradereport/user:view capability Given I log out And I log in as "admin" @@ -116,4 +111,4 @@ Feature: link to gradebook on the end of lesson page And I press "Next page" And I press "Next page" Then I should see "Congratulations - end of lesson reached" - And I should not see "View grades" \ No newline at end of file + And I should not see "View grades" diff --git a/mod/lesson/tests/behat/password_protection.feature b/mod/lesson/tests/behat/password_protection.feature index e5b3ee6f9b5..d175886e772 100644 --- a/mod/lesson/tests/behat/password_protection.feature +++ b/mod/lesson/tests/behat/password_protection.feature @@ -4,7 +4,6 @@ Feature: A teacher can password protect a lesson As a teacher I need to set a password to access the lesson - @javascript Scenario: Accessing as student to a protected lesson Given the following "users" exist: | username | firstname | lastname | email | diff --git a/mod/lesson/tests/behat/teacher_grade_essays.feature b/mod/lesson/tests/behat/teacher_grade_essays.feature index 5a9df9d3b11..203c7b8723c 100644 --- a/mod/lesson/tests/behat/teacher_grade_essays.feature +++ b/mod/lesson/tests/behat/teacher_grade_essays.feature @@ -3,7 +3,6 @@ Feature: In a lesson activity, a non editing teacher can grade essay questions As a non editing teacher I need to grade student answers to essay questions in lesson - @javascript Scenario: non editing teacher grade essay questions Given the following "users" exist: | username | firstname | lastname | email | @@ -79,11 +78,11 @@ Feature: In a lesson activity, a non editing teacher can grade essay questions | Essay score | 1 | And I press "Save changes" And I should see "Changes saved" - And I set the field "Separate groups" to "Group A" + And I select "Group A" from the "Separate groups" singleselect And I should see "Student 1" And I should not see "Student 2" - And I set the field "Separate groups" to "Group B" + And I select "Group B" from the "Separate groups" singleselect And I should see "Student 2" And I should not see "Student 1" - And I set the field "Separate groups" to "Group C" + And I select "Group C" from the "Separate groups" singleselect And I should see "No one in Group C has answered an essay question yet."