From cddd25272311dad9ebbe497961d6cfec4e223d74 Mon Sep 17 00:00:00 2001 From: jerome mouneyrac Date: Wed, 21 Apr 2010 06:30:50 +0000 Subject: [PATCH] web service MDL-21351 list of selectabl users should not include deleted user --- admin/webservice/lib.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/admin/webservice/lib.php b/admin/webservice/lib.php index c192dc29ec0..137b672ccbc 100644 --- a/admin/webservice/lib.php +++ b/admin/webservice/lib.php @@ -69,12 +69,13 @@ class service_user_selector extends user_selector_base { ///the following SQL retrieve all users that are allowed to the serviceid $sql = " FROM {user} u, {external_services_users} esu WHERE $wherecondition + AND u.deleted = 0 AND esu.userid = u.id AND esu.externalserviceid = :serviceid"; } else { ///the following SQL retrieve all users that are not allowed to the serviceid - $sql = " FROM {user} u WHERE $wherecondition + $sql = " FROM {user} u WHERE $wherecondition AND u.deleted = 0 AND NOT EXISTS (SELECT esu.userid FROM {external_services_users} esu WHERE esu.externalserviceid = :serviceid AND esu.userid = u.id)";