L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-31607 use full course object for require_login() if already available

Browse Source 
This eliminates 1 db query.
This commit is contained in:
Petr Skoda
2012-04-22 17:41:47 +02:00
parent ead4f180a0
commit cdbea7eed1
85 changed files with 88 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/feedback/analysis.php
+2 -2
View File
@@ -53,9 +53,9 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
}
if ($course->id == SITEID) {
require_login($course->id, true);
require_login($course, true);
} else {
require_login($course->id, true, $cm);
require_login($course, true, $cm);
}
//check whether the given courseid exists
mod/feedback/analysis_course.php
+1 -1
View File
@@ -72,7 +72,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
if (!($feedback->publish_stats OR has_capability('mod/feedback:viewreports', $context))) {
print_error('error');
mod/feedback/analysis_to_excel.php
+1 -1
View File
@@ -55,7 +55,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:viewreports', $context);
mod/feedback/complete.php
+2 -2
View File
@@ -114,9 +114,9 @@ if ($course->id == SITEID AND !has_capability('mod/feedback:edititems', $context
if ($feedback->anonymous != FEEDBACK_ANONYMOUS_YES) {
if ($course->id == SITEID) {
require_login($course->id, true);
require_login($course, true);
} else {
require_login($course->id, true, $cm);
require_login($course, true, $cm);
}
} else {
if ($course->id == SITEID) {
mod/feedback/delete_completed.php
+1 -1
View File
@@ -54,7 +54,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:deletesubmissions', $context);
mod/feedback/delete_item.php
+1 -1
View File
@@ -47,7 +47,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:edititems', $context);
mod/feedback/delete_template.php
+1 -1
View File
@@ -71,7 +71,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:deletetemplate', $context);
mod/feedback/edit.php
+1 -1
View File
@@ -61,7 +61,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:edititems', $context);
mod/feedback/edit_item.php
+1 -1
View File
@@ -71,7 +71,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:edititems', $context);
mod/feedback/export.php
+1 -1
View File
@@ -51,7 +51,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:edititems', $context);
mod/feedback/import.php
+1 -1
View File
@@ -56,7 +56,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:edititems', $context);
mod/feedback/index.php
+1 -1
View File
@@ -39,7 +39,7 @@ if (!$context = get_context_instance(CONTEXT_COURSE, $course->id)) {
print_error('badcontext');
}
require_login($course->id);
require_login($course);
$PAGE->set_pagelayout('incourse');
add_to_log($course->id, 'feedback', 'view all', $url->out(false), $course->id);
mod/feedback/mapcourse.php
+1 -1
View File
@@ -65,7 +65,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:mapcourse', $context);
mod/feedback/print.php
+1 -1
View File
@@ -45,7 +45,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:view', $context);
$PAGE->set_pagelayout('embedded');
mod/feedback/show_entries.php
+1 -1
View File
@@ -65,7 +65,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
if (($formdata = data_submitted()) AND !confirm_sesskey()) {
print_error('invalidsesskey');
mod/feedback/show_entries_anonym.php
+1 -1
View File
@@ -56,7 +56,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:viewreports', $context);
mod/feedback/show_nonrespondents.php
+1 -1
View File
@@ -74,7 +74,7 @@ if (!$coursecontext = get_context_instance(CONTEXT_COURSE, $course->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
if (($formdata = data_submitted()) AND !confirm_sesskey()) {
print_error('invalidsesskey');
mod/feedback/use_templ.php
+1 -1
View File
@@ -56,7 +56,7 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
require_login($course->id, true, $cm);
require_login($course, true, $cm);
require_capability('mod/feedback:edititems', $context);
mod/feedback/view.php
+2 -2
View File
@@ -76,9 +76,9 @@ if ($course->id == SITEID AND !has_capability('mod/feedback:edititems', $context
if ($feedback->anonymous != FEEDBACK_ANONYMOUS_YES) {
if ($course->id == SITEID) {
require_login($course->id, true);
require_login($course, true);
} else {
require_login($course->id, true, $cm);
require_login($course, true, $cm);
}
} else {
if ($course->id == SITEID) {