MDL-31607 use full course object for require_login() if already available
This eliminates 1 db query.
This commit is contained in:
+1
-1
@@ -68,7 +68,7 @@ if ($id) {
|
||||
}
|
||||
}
|
||||
|
||||
require_login($course->id, false, $cm);
|
||||
require_login($course, false, $cm);
|
||||
|
||||
if (isguestuser()) {
|
||||
redirect('view.php?d='.$data->id);
|
||||
|
||||
+1
-1
@@ -53,7 +53,7 @@ if (! $context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
|
||||
print_error('invalidcontext', '');
|
||||
}
|
||||
|
||||
require_login($course->id, false, $cm);
|
||||
require_login($course, false, $cm);
|
||||
require_capability(DATA_CAP_EXPORT, $context);
|
||||
|
||||
// get fields for this database
|
||||
|
||||
+1
-1
@@ -86,7 +86,7 @@ if ($id) {
|
||||
}
|
||||
}
|
||||
|
||||
require_login($course->id, true, $cm);
|
||||
require_login($course, true, $cm);
|
||||
|
||||
$context = get_context_instance(CONTEXT_MODULE, $cm->id);
|
||||
require_capability('mod/data:managetemplates', $context);
|
||||
|
||||
+1
-1
@@ -45,7 +45,7 @@ if ($id) {
|
||||
$cm = get_coursemodule_from_instance('data', $data->id, $course->id, null, MUST_EXIST);
|
||||
}
|
||||
$context = get_context_instance(CONTEXT_MODULE, $cm->id, MUST_EXIST);
|
||||
require_login($course->id, false, $cm);
|
||||
require_login($course, false, $cm);
|
||||
require_capability('mod/data:managetemplates', $context);
|
||||
$PAGE->set_url(new moodle_url('/mod/data/preset.php', array('d'=>$data->id)));
|
||||
$PAGE->set_title(get_string('course') . ': ' . $course->fullname);
|
||||
|
||||
@@ -64,7 +64,7 @@ if ($id) {
|
||||
}
|
||||
}
|
||||
|
||||
require_login($course->id, false, $cm);
|
||||
require_login($course, false, $cm);
|
||||
|
||||
$context = get_context_instance(CONTEXT_MODULE, $cm->id);
|
||||
require_capability('mod/data:managetemplates', $context);
|
||||
|
||||
Reference in New Issue
Block a user